From owner-freebsd-python@FreeBSD.ORG  Sun Sep  2 12:01:54 2012
Return-Path: <owner-freebsd-python@FreeBSD.ORG>
Delivered-To: python@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id ECBF31065673;
	Sun,  2 Sep 2012 12:01:54 +0000 (UTC)
	(envelope-from cvs-src@yandex.ru)
Received: from forward2h.mail.yandex.net (forward2h.mail.yandex.net
	[IPv6:2a02:6b8:0:f05::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 63E5F8FC1A;
	Sun,  2 Sep 2012 12:01:54 +0000 (UTC)
Received: from smtp1h.mail.yandex.net (smtp1h.mail.yandex.net [84.201.187.144])
	by forward2h.mail.yandex.net (Yandex) with ESMTP id DDCCC700E6D;
	Sun,  2 Sep 2012 16:01:52 +0400 (MSK)
Received: from smtp1h.mail.yandex.net (localhost [127.0.0.1])
	by smtp1h.mail.yandex.net (Yandex) with ESMTP id 8E0E01340023;
	Sun,  2 Sep 2012 16:01:52 +0400 (MSK)
Received: from unknown (unknown [178.76.224.133])
	by smtp1h.mail.yandex.net (nwsmtp/Yandex) with ESMTP id
	1qR0mJ3i-1qR03tlL; Sun,  2 Sep 2012 16:01:52 +0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail;
	t=1346587312; bh=FMYvER1ZzsjBtem6le74hmZuxRshvD/lCg1G3GvQWsE=;
	h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:
	References:In-Reply-To:Content-Type:Content-Transfer-Encoding;
	b=nKtR142gTkAzPKmgSVF80c0xJENjtiiNzv15Qdn9IJGhzOsUwJmrR1goS31HeRa59
	TY9SiqbGzjwturGCDKOYEeAvtTL754hl55vuZcpgYPGSh/r/AEg72MuC7Wk8H+iQii
	eAlUrSgCZnt93bDUoD/E1gaIrCgmSSDVgWaRlsM8=
Message-ID: <50434AAF.7070005@yandex.ru>
Date: Sun, 02 Sep 2012 16:01:51 +0400
From: Ruslan Mahmatkhanov <cvs-src@yandex.ru>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:14.0) Gecko/20120823 Thunderbird/14.0
MIME-Version: 1.0
To: Li-Wen Hsu <lwhsu@FreeBSD.org>
References: <50430B39.6040707@yandex.ru>
	<CAKBkRUyV_CBTdY4xN7K_6PH4rQN80oU9+pQpscbmdLz-qAW_NQ@mail.gmail.com>
In-Reply-To: <CAKBkRUyV_CBTdY4xN7K_6PH4rQN80oU9+pQpscbmdLz-qAW_NQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: python <python@freebsd.org>, portmgr@freebsd.org
Subject: Re: Simple change into Mk/bsd.python.mk
X-BeenThere: freebsd-python@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD-specific Python issues <freebsd-python.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-python>, 
	<mailto:freebsd-python-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-python>
List-Post: <mailto:freebsd-python@freebsd.org>
List-Help: <mailto:freebsd-python-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-python>,
	<mailto:freebsd-python-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Sep 2012 12:01:55 -0000

Hi Li-Wen,

Li-Wen Hsu wrote on 02.09.2012 14:03:
> On Sun, Sep 2, 2012 at 3:31 PM, Ruslan Mahmatkhanov <cvs-src@yandex.ru> wrote:
>> Hi,
>>
>> I'm preparing an update of www/plone and discovered thing that's need to be
>> changed to make USE_ZOPE knob actually work. We do not define ZOPESKELDIR
>> anymore, so the RUN_DEPENDS line should be fixed.
>> While here, trim some leftover from py24/25 removal, that's now always true
>> in current ports tree. Would you please approve this change?
>>
>> PS. It doesn't needed an exp-run because at the time there is no ports, that
>> use USE_ZOPE.
>
> Looks good to me, and if you don't mind, how about doing this:
>
>      RUN_DEPENDS+=	${LOCALBASE}/bin/zopectl:${ZOPE_PORTSDIR}
>
> in this way:
>
>      RUN_DEPENDS+=	zope213>0:${ZOPE_PORTSDIR}
>
> or even replace this:
>
>      ZOPE_PORTSDIR=	${PORTSDIR}/www/zope213
>
> with:
>
>      ZOPE_DEPENDS=	zope213>0:${PORTSDIR}/www/zope213
>
> and then, .if defined(USE_ZOPE) section can be written as:
>
>      RUN_DEPENDS+=	${ZOPE_DEPENDS}
>
> How do you think?
>

I believe that original intention was not to hardcode the zope port 
version. Yes, there is only one zope version at the moment, but there 
may be more in future. Just though about ports that needs different zope 
versions. Please tell me if I understand it wrong.

-- 
Regards,
Ruslan

Tinderboxing kills... the drives.