Date: Sun, 02 Sep 2012 16:01:51 +0400 From: Ruslan Mahmatkhanov <cvs-src@yandex.ru> To: Li-Wen Hsu <lwhsu@FreeBSD.org> Cc: python <python@freebsd.org>, portmgr@freebsd.org Subject: Re: Simple change into Mk/bsd.python.mk Message-ID: <50434AAF.7070005@yandex.ru> In-Reply-To: <CAKBkRUyV_CBTdY4xN7K_6PH4rQN80oU9%2BpQpscbmdLz-qAW_NQ@mail.gmail.com> References: <50430B39.6040707@yandex.ru> <CAKBkRUyV_CBTdY4xN7K_6PH4rQN80oU9%2BpQpscbmdLz-qAW_NQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Li-Wen,
Li-Wen Hsu wrote on 02.09.2012 14:03:
> On Sun, Sep 2, 2012 at 3:31 PM, Ruslan Mahmatkhanov <cvs-src@yandex.ru> wrote:
>> Hi,
>>
>> I'm preparing an update of www/plone and discovered thing that's need to be
>> changed to make USE_ZOPE knob actually work. We do not define ZOPESKELDIR
>> anymore, so the RUN_DEPENDS line should be fixed.
>> While here, trim some leftover from py24/25 removal, that's now always true
>> in current ports tree. Would you please approve this change?
>>
>> PS. It doesn't needed an exp-run because at the time there is no ports, that
>> use USE_ZOPE.
>
> Looks good to me, and if you don't mind, how about doing this:
>
> RUN_DEPENDS+= ${LOCALBASE}/bin/zopectl:${ZOPE_PORTSDIR}
>
> in this way:
>
> RUN_DEPENDS+= zope213>0:${ZOPE_PORTSDIR}
>
> or even replace this:
>
> ZOPE_PORTSDIR= ${PORTSDIR}/www/zope213
>
> with:
>
> ZOPE_DEPENDS= zope213>0:${PORTSDIR}/www/zope213
>
> and then, .if defined(USE_ZOPE) section can be written as:
>
> RUN_DEPENDS+= ${ZOPE_DEPENDS}
>
> How do you think?
>
I believe that original intention was not to hardcode the zope port
version. Yes, there is only one zope version at the moment, but there
may be more in future. Just though about ports that needs different zope
versions. Please tell me if I understand it wrong.
--
Regards,
Ruslan
Tinderboxing kills... the drives.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50434AAF.7070005>