From owner-freebsd-bugs@FreeBSD.ORG Fri Jun 29 21:00:23 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 84EF91065675 for ; Fri, 29 Jun 2012 21:00:23 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 51AD78FC19 for ; Fri, 29 Jun 2012 21:00:23 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5TL0NRj049164 for ; Fri, 29 Jun 2012 21:00:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5TL0NWt049163; Fri, 29 Jun 2012 21:00:23 GMT (envelope-from gnats) Resent-Date: Fri, 29 Jun 2012 21:00:23 GMT Resent-Message-Id: <201206292100.q5TL0NWt049163@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mark Johnston Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E4C651065672 for ; Fri, 29 Jun 2012 20:57:00 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id B67638FC18 for ; Fri, 29 Jun 2012 20:57:00 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q5TKv0Nv082214 for ; Fri, 29 Jun 2012 20:57:00 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q5TKv01L082213; Fri, 29 Jun 2012 20:57:00 GMT (envelope-from nobody) Message-Id: <201206292057.q5TKv01L082213@red.freebsd.org> Date: Fri, 29 Jun 2012 20:57:00 GMT From: Mark Johnston To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/169557: [patch][lagg] handle interface renames X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2012 21:00:23 -0000 >Number: 169557 >Category: kern >Synopsis: [patch][lagg] handle interface renames >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jun 29 21:00:22 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Mark Johnston >Release: CURRENT >Organization: Sandvine Inc. >Environment: $ uname -a FreeBSD oddish 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r237569+921e55b: Mon Jun 25 17:56:13 EDT 2012 mark@oddish:/home/mark/src/obj/usr/home/mark/src/freebsd/sys/GENERIC amd64 >Description: Renaming an interface that's part of a lagg will cause if_lagg(4) to remove it from the group. This is because if_lagg(4) sees the interface's departure event and assumes it's leaving forever. With a rename, this isn't the case. >How-To-Repeat: # ifconfig lagg0 create # ifconfig lagg0 laggproto failover laggport re0 # ifconfig re0 re0: flags=8843 metric 0 mtu 1500 options=8209b ether f0:de:f1:9c:8e:a9 inet 192.168.200.21 netmask 0xfffffe00 broadcast 192.168.201.255 nd6 options=29 media: Ethernet autoselect (100baseTX ) status: active # ifconfig lagg0 lagg0: flags=8843 metric 0 mtu 1500 options=8209b ether f0:de:f1:9c:8e:a9 inet 192.168.200.21 netmask 0xfffffe00 broadcast 192.168.201.255 nd6 options=29 media: Ethernet autoselect status: active laggproto failover lagghash l2,l3,l4 laggport: re0 flags=5 # ifconfig re0 name foo0 # ifconfig lagg0 lagg0: flags=8843 metric 0 mtu 1500 ether 00:00:00:00:00:00 inet 192.168.200.21 netmask 0xfffffe00 broadcast 192.168.201.255 nd6 options=29 media: Ethernet autoselect status: no carrier laggproto failover lagghash l2,l3,l4 >Fix: Apply the patch. There is an identical check in the corresponding function for if_vlan(4). Patch attached with submission follows: diff --git a/sys/net/if_lagg.c b/sys/net/if_lagg.c index 9041e18..af2fdbc 100644 --- a/sys/net/if_lagg.c +++ b/sys/net/if_lagg.c @@ -797,6 +797,8 @@ lagg_port_ifdetach(void *arg __unused, struct ifnet *ifp) if ((lp = ifp->if_lagg) == NULL) return; + if (ifp->if_flags & IFF_RUNNING) + return; sc = lp->lp_softc; >Release-Note: >Audit-Trail: >Unformatted: