From owner-svn-src-all@FreeBSD.ORG Wed Feb 25 17:05:07 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BCCF71065670; Wed, 25 Feb 2009 17:05:07 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [62.111.66.27]) by mx1.freebsd.org (Postfix) with ESMTP id 69F478FC16; Wed, 25 Feb 2009 17:05:07 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from localhost (amavis.str.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 9C58741C6B4; Wed, 25 Feb 2009 18:05:05 +0100 (CET) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([62.111.66.27]) by localhost (amavis.str.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id oVG-plkqXG-N; Wed, 25 Feb 2009 18:05:05 +0100 (CET) Received: by mail.cksoft.de (Postfix, from userid 66) id 0986341C677; Wed, 25 Feb 2009 18:05:05 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id A0CC54448E6; Wed, 25 Feb 2009 17:03:52 +0000 (UTC) Date: Wed, 25 Feb 2009 17:03:52 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: John Baldwin In-Reply-To: <200902251142.38334.jhb@freebsd.org> Message-ID: <20090225170115.R53478@maildrop.int.zabbadoz.net> References: <200902251504.n1PF4UjR000511@svn.freebsd.org> <49A571BE.4060107@cs.duke.edu> <200902251142.38334.jhb@freebsd.org> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org, Andrew Gallatin Subject: Re: svn commit: r189044 - in stable/7/sys: . contrib/pf dev/ath/ath_hal dev/cxgb kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Feb 2009 17:05:08 -0000 On Wed, 25 Feb 2009, John Baldwin wrote: > On Wednesday 25 February 2009 11:28:46 am Andrew Gallatin wrote: >> Just picking a commit at random, but is there any way >> to clean up the props on pf, ath and cxgb: >> >>> stable/7/sys/contrib/pf/ (props changed) >>> stable/7/sys/dev/ath/ath_hal/ (props changed) >>> stable/7/sys/dev/cxgb/ (props changed) >>> stable/7/sys/kern/kern_descrip.c >> >> Or at the very least, have the email script ignore them? >> >> Having this props change garbage always in the $SUBJECT of >> MFCs makes it very hard to distinguish from the commit >> message what part of the tree is actually changing. > > In theory the mail script is just a python script in svnadmin so we can change > it. I know several folks miss the subject lines from CVS that had all the > filenames (so you could easily search for commit e-mails to a file by > searching subjects in a mail client like kmail), and excluding paths that > only have property changes at the same time would probably be good. I think there are two points here: 1) the svn interface; I remember peter mumbling something about old we use and new one. Maybe that was for something else. 2) the script itself seems very readable but it made me run away last time I tried to look at this. If you like python and have a svn test installation with the freebsd setup it's probably fixable; we could at least sort the prop-only changes to the end of the subject. I think we might need to keep them for the time when people do svn merge --record-only as that ends to be a prop-only change as well. -- Bjoern A. Zeeb The greatest risk is not taking one.