Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 9 Aug 2023 17:20:31 GMT
From:      Kevin Bowling <kbowling@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 13da84237a37 - main - e1000: Enable TSO on 82574
Message-ID:  <202308091720.379HKV7j019969@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by kbowling:

URL: https://cgit.FreeBSD.org/src/commit/?id=13da84237a37961938e9e237171ac111ddc1897c

commit 13da84237a37961938e9e237171ac111ddc1897c
Author:     Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2023-08-09 17:18:37 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2023-08-09 17:19:37 +0000

    e1000: Enable TSO on 82574
    
    Further testing indicates something wrong with particular reciever,
    enabling TSO 82574 for wider testing.
    
    Tested by:      karels
    MFC after:      3 months
---
 sys/dev/e1000/if_em.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c
index fefd1e3f411c..069ff37c6a75 100644
--- a/sys/dev/e1000/if_em.c
+++ b/sys/dev/e1000/if_em.c
@@ -906,9 +906,6 @@ em_if_attach_pre(if_ctx_t ctx)
 		scctx->isc_tx_csum_flags = CSUM_TCP | CSUM_UDP | CSUM_IP_TSO |
 		    CSUM_IP6_TCP | CSUM_IP6_UDP;
 
-		/* Disable TSO on 82574L due to performance loss being investigated */
-		if (hw->mac.type == e1000_82574)
-			scctx->isc_capenable &= ~IFCAP_TSO;
 		/*
 		 * Disable TSO on SPT due to errata that downclocks DMA performance
 		 * i218-i219 Specification Update 1.5.4.5



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202308091720.379HKV7j019969>