Date: Wed, 25 Jul 2012 02:46:28 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Carlo Strub <cs@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r301497 - in head: databases/rubygem-dm-migrations deskutils/libgcal deskutils/p5-ZConf-BGSet deskutils/p5-ZConf-Runner deskutils/xrolo devel/alabastra devel/librcd devel/py-pytemplate ... Message-ID: <20120725024628.GA3065@FreeBSD.org> In-Reply-To: <500F5B18.1010105@FreeBSD.org> References: <201207242127.q6OLRE9x075919@svn.freebsd.org> <20120725022501.GA98315@FreeBSD.org> <500F5B18.1010105@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 24, 2012 at 07:34:00PM -0700, Doug Barton wrote: > On 07/24/2012 19:25, Alexey Dokuchaev wrote: > >> -COMMENT= Run a file using a choosen methode, desktop entry or mimetype > >> +COMMENT= Run a file using a chosen method, desktop entry or mimetype > > > > This could benefit from comma before "or" I think. > > Search for "Oxford comma" for more info on this. Short version, it's > allowed at minimum, many would also say preferred, but it is not mandatory. I see. I tend to agree, but in this particular case it seems to improve readability a bit (I've been reading this COMMENT several tens times with and w/out the comma). > >> -COMMENT= A MSN Messenger client writen in python > >> +COMMENT= A MSN Messenger client written in python > > > > Shouldn't it be "An MSN ... in Python" ? > > Our comment format is to not start with a leading article at all. So > just "MSN Messenger ..." Now that you've mentioned it, yes, we have a large diversity in using indefinite article in the beginning of COMMENT line. I would also want us to settle on some standard. If you say it should be dropped, so let it be. Thanks for following up on this Doug. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120725024628.GA3065>