From owner-svn-ports-head@FreeBSD.ORG Fri Mar 14 09:44:15 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6BE1FE23; Fri, 14 Mar 2014 09:44:15 +0000 (UTC) Received: from mail.lysator.liu.se (mail.lysator.liu.se [IPv6:2001:6b0:17:f0a0::3]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E89F8E8B; Fri, 14 Mar 2014 09:44:14 +0000 (UTC) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 47FCF4002B; Fri, 14 Mar 2014 10:44:13 +0100 (CET) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 3DDBD4001D; Fri, 14 Mar 2014 10:44:13 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=AWL autolearn=disabled version=3.3.1 X-Spam-Score: 0.0 Received: from mx.daemonic.se (mx.daemonic.se [IPv6:2001:470:dca9:0:1::3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id E422B40018; Fri, 14 Mar 2014 10:44:11 +0100 (CET) Received: from mailscanner.daemonic.se (mailscanner.daemonic.se [IPv6:2001:470:dca9:0:1::6]) by mx.daemonic.se (Postfix) with ESMTPS id 3flhnR2Q7Kz8gh2; Fri, 14 Mar 2014 10:44:11 +0100 (CET) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mx.daemonic.se ([IPv6:2001:470:dca9:0:1::3]) (using TLS with cipher CAMELLIA256-SHA) by mailscanner.daemonic.se (mailscanner.daemonic.se [IPv6:2001:470:dca9:0:1::6]) (amavisd-new, port 10025) with ESMTPS id AcU64DA410zX; Fri, 14 Mar 2014 10:44:08 +0100 (CET) Received: from mail.daemonic.se (mail.daemonic.se [10.1.0.4]) by mx.daemonic.se (Postfix) with ESMTPS id 3flhnN6JCZz8ggv; Fri, 14 Mar 2014 10:44:08 +0100 (CET) Received: from [IPv6:::1] (celes.daemonic.se [IPv6:2001:470:dca9:1::3]) by mail.daemonic.se (Postfix) with ESMTPSA id 3flhnN3pvZz9D6J; Fri, 14 Mar 2014 10:44:08 +0100 (CET) Message-ID: <5322CF65.2090405@freebsd.org> Date: Fri, 14 Mar 2014 10:44:05 +0100 From: Niclas Zeising User-Agent: Mutt/1.5.21 MIME-Version: 1.0 To: Antoine Brodin Subject: Re: svn commit: r348113 - head/graphics/libEGL References: <201403131835.s2DIZS7s028667@svn.freebsd.org> <5321FC4C.9070503@freebsd.org> <5322008C.6010600@freebsd.org> <5322BE33.4070003@freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 140313-1, 2014-03-13), Outbound message X-Antivirus-Status: Clean X-Virus-Scanned: ClamAV using ClamSMTP Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" , David Chisnall , Adam Weinberger X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Mar 2014 09:44:15 -0000 On 2014-03-14 10:10, Antoine Brodin wrote: > On Fri, Mar 14, 2014 at 9:30 AM, Niclas Zeising wrote: >> As far as I know, this was not a security related issue. It was a bug >> in a ports makefile in a piece of xorg that is not used/installed by >> default. > > Hi, > > 28 ports depend on it (via x11/kde4-workspace), this was enough to > trigger an investigation from me (with my portmgr hat) I did not know that it had such many dependent ports already, since it was added less than 6 months ago and is only used with WITH_NEW_XORG, which hasn't been the default in 11 for so long, and isn't the default anywhere else. With that said, I did not know that you were part of portmgr when you made the commit, and I had just seen your email to x11@, so I did not have very much time to react before this was committed. I apologize if I was a bit harsh in my reply. Lastly, if you can give us a little more time before acting the next time, or at least a reminder and/or a poke after the commit that would be very nice. It's easy to loose or miss mail on any public mailing list. It would also have been nice if you had added with hat: portmgr or something like that to the commit message. Also, a question for portmgr as a whole. Is there a list of members somewhere? I can only find an outdated wiki article (https://wiki.freebsd.org/portmgr), and that says at the top that it's under construction and refers to another page instead. Regards! -- Niclas