Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 22 Dec 2016 15:09:09 -0500
From:      Pedro Giffuni <pfg@FreeBSD.org>
To:        Ed Maste <emaste@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r310425 - in head/sys/dev/mlx4: mlx4_core mlx4_ib
Message-ID:  <e8792175-81e3-9c0e-7653-53fc0fc8850f@FreeBSD.org>
In-Reply-To: <201612221826.uBMIQLFQ076247@repo.freebsd.org>
References:  <201612221826.uBMIQLFQ076247@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help


On 22/12/2016 13:26, Ed Maste wrote:
> Author: emaste
> Date: Thu Dec 22 18:26:21 2016
> New Revision: 310425
> URL: https://svnweb.freebsd.org/changeset/base/310425
>
> Log:
>    mlx: avoid use of __DATE__ to make build reproducible
>    
>    Reviewed by:	hselasky
>    Differential Revision:	https://reviews.freebsd.org/D8886
Hmm ...
Sadly opengrok[*] reveals many uses of __DATE__.

I am wondering if there is some way to have it replaced with the SVN 
Date keyword.

Pedro.

*
http://src.illumos.org/source/search?q=__DATE__&defs=&refs=&path=&hist=&project=freebsd-head

> Modified:
>    head/sys/dev/mlx4/mlx4_core/mlx4.h
>    head/sys/dev/mlx4/mlx4_ib/mlx4_ib_main.c
>
> Modified: head/sys/dev/mlx4/mlx4_core/mlx4.h
> ==============================================================================
> --- head/sys/dev/mlx4/mlx4_core/mlx4.h	Thu Dec 22 18:05:22 2016	(r310424)
> +++ head/sys/dev/mlx4/mlx4_core/mlx4.h	Thu Dec 22 18:26:21 2016	(r310425)
> @@ -52,7 +52,7 @@
>   #define DRV_NAME	"mlx4_core"
>   #define PFX		DRV_NAME ": "
>   #define DRV_VERSION	"2.1.6"
> -#define DRV_RELDATE	__DATE__
> +#define DRV_RELDATE	"Sep 30 2016"
>   
>   #define DRV_STACK_NAME		"Linux-MLNX_OFED"
>   #define DRV_STACK_VERSION	"2.1"
>
> Modified: head/sys/dev/mlx4/mlx4_ib/mlx4_ib_main.c
> ==============================================================================
> --- head/sys/dev/mlx4/mlx4_ib/mlx4_ib_main.c	Thu Dec 22 18:05:22 2016	(r310424)
> +++ head/sys/dev/mlx4/mlx4_ib/mlx4_ib_main.c	Thu Dec 22 18:26:21 2016	(r310425)
> @@ -59,7 +59,7 @@
>   
>   #define DRV_NAME	MLX4_IB_DRV_NAME
>   #define DRV_VERSION	"1.0"
> -#define DRV_RELDATE	__DATE__
> +#define DRV_RELDATE	"Sep 30 2016"
>   
>   #define MLX4_IB_DRIVER_PROC_DIR_NAME "driver/mlx4_ib"
>   #define MLX4_IB_MRS_PROC_DIR_NAME "mrs"
>




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e8792175-81e3-9c0e-7653-53fc0fc8850f>