Date: Wed, 22 Jul 2015 15:49:57 +0200 From: Pietro Cerutti <gahr@FreeBSD.org> To: marino@freebsd.org Cc: Alexey Dokuchaev <danfe@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org Subject: Re: svn commit: r392666 - head/audio/libgroove Message-ID: <f3cbb7e65537d1385c474bc6dc57fbbb@gahr.ch> In-Reply-To: <55AF9C0C.9040601@marino.st> References: <201507220652.t6M6qVFO094263@repo.freebsd.org> <d4dfd69de717fd8d4e5ef472408644e1@gahr.ch> <20150722122313.GA50653@FreeBSD.org> <20150722122531.GB50653@FreeBSD.org> <de0f94bb48432295c450da4dffbd4ba6@gahr.ch> <55AF9AAC.8000106@marino.st> <9e0f61d80cec95a2ff54af98f1421878@gahr.ch> <55AF9C0C.9040601@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2015-07-22 15:35, John Marino wrote: > On 7/22/2015 3:32 PM, Pietro Cerutti wrote: >> On 2015-07-22 15:29, John Marino wrote: >>> On 7/22/2015 2:44 PM, Pietro Cerutti wrote: >>>> On 2015-07-22 14:25, Alexey Dokuchaev wrote: >>>> In clear contrast with the PHB, which states "If this line is >>>> present, >>>> future maintainers must >>>> not change or remove it except at the original author's request." >>>> >>>> It does *not* say "Future maintainers can change it if not >>>> explicitly >>>> asked not to.". >>>> >>>> Look, we do have rules so we don't have to argue about taste, style, >>>> what's more sensible to you, etc. >>>> >>>>> Sorry I forgot to ask: so any problem with expansion? >>>> >>>> Yes, I do. Please revert. >>>> >>> >>> So reverting it obviously goes against current practice. Is the >>> "problem" one of principle? In other words, are you torqued because >>> danfe touched the makefile, so you want him to revert it regardless >>> of >>> the commit itself? From afar, this appears like you are trying to >>> make >>> a point at the expense of the ports tree. >> >> I never meant to revert the whole commit, sorry for the wording. Does >> 'please get back the "Created by" line as it was before' sound ok? > > I knew that's what you meant, and that's what I'm talking about. The > expanded name is the defacto standard and this was hammered into me > during mentering. You're going out of your way to go against this > without explaining why, so I'm curious as to why. Danfe just didn't > make this up. Alright, I accept your de-facto standard. Please update the PHB accordingly, so it's not de-facto anymore and we don't have to talk about it next time. [The optional Created by: line names the person who originally created the port. Note that the “:” is followed by a space and not a tab character. The format should be an RFC822-compliant address, including the full name and the email address. If this line is present, future maintainers must not change or remove it except at the original author's request or to bring it in line with the format specified above.] And regarding your question, the reason why I'm asking the "Created by" line not to be changed is because I don't like my name appearing here and there without me knowing about it. And I'm really not about to enter a discussion about this. -- Pietro Cerutti gahr@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f3cbb7e65537d1385c474bc6dc57fbbb>