From owner-svn-src-projects@freebsd.org  Thu Dec 24 02:05:51 2015
Return-Path: <owner-svn-src-projects@freebsd.org>
Delivered-To: svn-src-projects@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EA24AA4ECA2
 for <svn-src-projects@mailman.ysv.freebsd.org>;
 Thu, 24 Dec 2015 02:05:51 +0000 (UTC)
 (envelope-from asomers@gmail.com)
Received: from mail-ob0-x235.google.com (mail-ob0-x235.google.com
 [IPv6:2607:f8b0:4003:c01::235])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id B6C081882;
 Thu, 24 Dec 2015 02:05:51 +0000 (UTC)
 (envelope-from asomers@gmail.com)
Received: by mail-ob0-x235.google.com with SMTP id 18so177665679obc.2;
 Wed, 23 Dec 2015 18:05:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type:content-transfer-encoding;
 bh=Dgf1pLI6aKx37VjIj2cCCytV400UycbfxfCPC9idiwM=;
 b=fb7QpQpOWf68cEzOiCNBVqdpSw6Jbr0GIgEv01IgnrQ81Vgirz0atEOaO0iKgYn2NK
 93AyJrfNO75N2pc4QHO06UdgxoytCiLgMv7IvT6olpzhhC1TKH98izOJ17D5/8oYt5Ly
 VrVeZDTwgs2X1VOlkGit+5L9/BS0bqpHZmZIWMw7JHjl0vjfmYjwkhPEQySWNbn9QV8Q
 fHa6dnc4P9WHv+vl3gwvO5pG1Xg8qZOqC4nGTpCDJkQAqQHoOpA0ztD95blN47ytzZfC
 cajKzKmfe1AtIjUjj3QFV+QVYhOhT8yafutzrB1p/UaW1OxuVLj8J3rXq1/axziMJmoe
 C+7Q==
MIME-Version: 1.0
X-Received: by 10.60.132.199 with SMTP id ow7mr16846621oeb.67.1450922750917;
 Wed, 23 Dec 2015 18:05:50 -0800 (PST)
Sender: asomers@gmail.com
Received: by 10.202.69.84 with HTTP; Wed, 23 Dec 2015 18:05:50 -0800 (PST)
In-Reply-To: <C47C4598-67DF-4DED-BFF4-BDFC460A7AD6@gmail.com>
References: <201512232335.tBNNZXra019877@repo.freebsd.org>
 <C47C4598-67DF-4DED-BFF4-BDFC460A7AD6@gmail.com>
Date: Wed, 23 Dec 2015 19:05:50 -0700
X-Google-Sender-Auth: Qi91AbCL75X2DUXMY3i1h0e1Qg4
Message-ID: <CAOtMX2i1hLs3QKOxCoOOg-_beQEr3j1vT5uL_j81p5OadPJviA@mail.gmail.com>
Subject: Re: svn commit: r292675 - projects/zfsd/head/share/mk
From: Alan Somers <asomers@freebsd.org>
To: NGie Cooper <yaneurabeya@gmail.com>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>,
 svn-src-projects@freebsd.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Dec 2015 02:05:52 -0000

On Wed, Dec 23, 2015 at 5:02 PM, NGie Cooper <yaneurabeya@gmail.com> wrote:
>
>> On Dec 23, 2015, at 15:35, Alan Somers <asomers@FreeBSD.org> wrote:
>>
>> Author: asomers
>> Date: Wed Dec 23 23:35:32 2015
>> New Revision: 292675
>> URL: https://svnweb.freebsd.org/changeset/base/292675
>>
>> Log:
>>  Fix typo from r292666
>>
>>  Sponsored by:        Spectra Logic Corp
>>
>> Modified:
>>  projects/zfsd/head/share/mk/atf.test.mk
>>
>> Modified: projects/zfsd/head/share/mk/atf.test.mk
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- projects/zfsd/head/share/mk/atf.test.mk   Wed Dec 23 22:45:17 2015  =
      (r292674)
>> +++ projects/zfsd/head/share/mk/atf.test.mk   Wed Dec 23 23:35:32 2015  =
      (r292675)
>> @@ -95,7 +95,7 @@ CLEANFILES+=3D ${_T} ${_T}.tmp
>> ATF_TESTS_KSH93_SED_${_T}?=3D # empty
>> ATF_TESTS_KSH93_SRC_${_T}?=3D ${_T}.sh
>> ${_T}: ${ATF_TESTS_KSH93_SRC_${_T}}
>> -     echo '#! /usr/libexec/atf-sh' > ${.TARGET}.tmp
>> +     echo '#! /usr/libexec/atf-ksh93' > ${.TARGET}.tmp
>> .if empty(ATF_TESTS_KSH93_SED_${_T})
>>       cat ${.ALLSRC:N*Makefile*} >>${.TARGET}.tmp
>> .else
>
> Hi Alan,
>         I=E2=80=99ve been watching some of these commits =E2=80=94 I was =
wondering if you=E2=80=99d be for taking all of the IllumOS specific testca=
se logic out of atf.test.mk (to keep it =E2=80=9Cclean=E2=80=9D per se) and=
 be open to putting this into a separate .test.mk file, similar to the one =
that Mark Johnston started for dtrace: ^/head/cddl/usr.sbin/dtrace/tests/dt=
race.test.mk ?
> Thanks!
> -NGie

Yeah, I think we can do that.  It hadn't occured to me to use separate
.mk files for a subdirectory of tests.
-Alan