From owner-svn-src-all@freebsd.org  Wed Jul  8 19:47:09 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DBBB5996C4D;
 Wed,  8 Jul 2015 19:47:09 +0000 (UTC)
 (envelope-from jmg@gold.funkthat.com)
Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client CN "gold.funkthat.com", Issuer "gold.funkthat.com" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id BC3F818E1;
 Wed,  8 Jul 2015 19:47:09 +0000 (UTC)
 (envelope-from jmg@gold.funkthat.com)
Received: from gold.funkthat.com (localhost [127.0.0.1])
 by gold.funkthat.com (8.14.5/8.14.5) with ESMTP id t68Jl88b030517
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Wed, 8 Jul 2015 12:47:08 -0700 (PDT)
 (envelope-from jmg@gold.funkthat.com)
Received: (from jmg@localhost)
 by gold.funkthat.com (8.14.5/8.14.5/Submit) id t68Jl8Nu030516;
 Wed, 8 Jul 2015 12:47:08 -0700 (PDT) (envelope-from jmg)
Date: Wed, 8 Jul 2015 12:47:08 -0700
From: John-Mark Gurney <jmg@funkthat.com>
To: Zbigniew Bodek <zbb@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r285270 - head/sys/sys
Message-ID: <20150708194708.GQ8523@funkthat.com>
References: <201507081353.t68Dr0up028388@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201507081353.t68Dr0up028388@repo.freebsd.org>
X-Operating-System: FreeBSD 9.1-PRERELEASE amd64
X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88  9322 9CB1 8F74 6D3F A396
X-Files: The truth is out there
X-URL: http://resnet.uoregon.edu/~gurney_j/
X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html
X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE
X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger?
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7
 (gold.funkthat.com [127.0.0.1]); Wed, 08 Jul 2015 12:47:09 -0700 (PDT)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jul 2015 19:47:10 -0000

Zbigniew Bodek wrote this message on Wed, Jul 08, 2015 at 13:53 +0000:
> +#if defined(__arm__)
> +	#define __BUS_DMAMAP_SYNC_DEFAULT		mb();
> +#elif defined(__aarch64__)
> +	#define	__BUS_DMAMAP_SYNC_DEFAULT		dmb(sy);

These shouldn't have ; after them...

> +#else
> +	#define	__BUS_DMAMAP_SYNC_DEFAULT		{}

The correct spelling of this should probably be:
do {  } while (0)

> +#endif
>  #define bus_dmamap_sync(dmat, dmamap, op) 			\
>  	do {							\
>  		if ((dmamap) != NULL)				\
>  			_bus_dmamap_sync(dmat, dmamap, op);	\
> +		else						\
> +			__BUS_DMAMAP_SYNC_DEFAULT		\

And then this can be properly written w/ a ; at the end...

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."