From owner-freebsd-current@FreeBSD.ORG Fri Aug 1 11:25:18 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BF2AB37B404 for ; Fri, 1 Aug 2003 11:25:18 -0700 (PDT) Received: from wall.polstra.com (wall-gw.polstra.com [206.213.73.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id A98BC43FDF for ; Fri, 1 Aug 2003 11:25:17 -0700 (PDT) (envelope-from jdp@polstra.com) Received: from strings.polstra.com (strings.polstra.com [206.213.73.20]) by wall.polstra.com (8.12.3p2/8.12.3) with ESMTP id h71IPFfK063454 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Fri, 1 Aug 2003 11:25:15 -0700 (PDT) (envelope-from jdp@strings.polstra.com) Received: (from jdp@localhost) by strings.polstra.com (8.12.6/8.12.6/Submit) id h71IPEAs072047; Fri, 1 Aug 2003 11:25:14 -0700 (PDT) (envelope-from jdp) Date: Fri, 1 Aug 2003 11:25:14 -0700 (PDT) Message-Id: <200308011825.h71IPEAs072047@strings.polstra.com> To: current@freebsd.org From: John Polstra In-Reply-To: <20030801175724.F1C6D43F75@mx1.FreeBSD.org> References: <20030801175724.F1C6D43F75@mx1.FreeBSD.org> Organization: Polstra & Co., Seattle, WA X-Bogosity: No, tests=bogofilter, spamicity=0.500000, version=0.11.2 cc: pmedwards@eircom.net Subject: Re: bge & vlan stranges X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Aug 2003 18:25:19 -0000 In article <20030801175724.F1C6D43F75@mx1.FreeBSD.org>, Peter Edwards wrote: > John Polstra wrote: > > [snip] > >> I assume you mean, that after setting if_hdrlen, > [snip] > > I think you also have to set if_data.ifi_hdrlen as I said > [snip] > > My fault: I jumped from one term for the same thing to the other > without explanation. if_hdrlen is a macro for if_data.ifi_hdrlen. Understood. I was just trying to make the point that you have to set that in addition to setting the MTU register in the hardware. > I'm not a big fan of hiding those kind of details with macros, but I > assume they're defined by smarter people than me in order that > they be used :-) I don't know why the fxp driver doesn't use the macro. Maybe the macro didn't exist yet when that code was added. John -- John Polstra John D. Polstra & Co., Inc. Seattle, Washington USA "Two buttocks cannot avoid friction." -- Malawi saying