From owner-freebsd-current@FreeBSD.ORG  Thu Feb 12 12:43:48 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B9E7016A4D7
	for <current@freebsd.org>; Thu, 12 Feb 2004 12:43:48 -0800 (PST)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1541343D2F
	for <current@freebsd.org>; Thu, 12 Feb 2004 12:43:48 -0800 (PST)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.10/8.12.10) with ESMTP id i1CKhgMW028392;
	Thu, 12 Feb 2004 21:43:47 +0100 (CET)
	(envelope-from phk@phk.freebsd.dk)
To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Thu, 12 Feb 2004 20:32:52 GMT."
             <Pine.BSF.4.53.0402122023480.69801@e0-0.zab2.int.zabbadoz.net> 
Date: Thu, 12 Feb 2004 21:43:42 +0100
Message-ID: <28391.1076618622@critter.freebsd.dk>
cc: FreeBSD current mailing list <current@freebsd.org>
cc: "Bjoern A. Zeeb" <bzeeb+freebsd@zabbadoz.net>
Subject: Re: dev/random duplicate call to destroy_dev 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Feb 2004 20:43:48 -0000

In message <Pine.BSF.4.53.0402122023480.69801@e0-0.zab2.int.zabbadoz.net>, "Bjo
ern A. Zeeb" writes:
>Hi,
>
>when unloading random module destry_dev also gets called for dev_t
>aquired with make_dev_alias which is wrong according to make_dev(9).
>
>Seems this has been living in there for 3y7m now ...
>http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/random/randomdev.c.diff?r1=1.3&r2=1.4
>
>possible yet untested fix:

Correctly diagnosed, thanks!

Poul-Henning

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.