From owner-svn-src-head@freebsd.org Mon Mar 11 02:24:27 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE1031528C58 for ; Mon, 11 Mar 2019 02:24:26 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8316D7363D for ; Mon, 11 Mar 2019 02:24:25 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72b.google.com with SMTP id c189so899072qke.6 for ; Sun, 10 Mar 2019 19:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t83DPOiEb8StNtEMX1wiZcpkXFBlXH5lDIUpA8kwqak=; b=YASHFDu2zt/a/YsjGG3Otn1ZEsWJDZU/9BTd647d4jH4MR80coRc5PXE+ppakwa5cr 7yVxJKPYT+1TFBYl7hbC4gwdrI8YN1aNfP56MR2RMORB27z8Edxe8HbM3L6UPaC+AntW 5hGVXwX5XilpLUUHGgT4LYvwIwqjgfwnyFXOo7FNYKV0zvC8Tn/FN6xCoJkN9lvF/HdM YdOX+H4HO4smjy7uVFHm6k94zJtFbcJ0sD4XRFDxhzU5/b+mtBTyDJt4iO7yCA/K5tYE 2ISsWj3gKD1EuZ27qJUD/9js9cFSgsDd9H8mgJ/NWc8d3zoQFa3MgMSzZJhbNyaPPb7M bQBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t83DPOiEb8StNtEMX1wiZcpkXFBlXH5lDIUpA8kwqak=; b=okI3lYmQRmPR0vd/kCtMmc0js6yx6TIrJJB88Pmvg2PggW18LXnpyTaPXwwOSIZ6xG 2zj4ZCTJ8v1w4qmBjQv0ld7G4t04GRMlLSNpzHQQQ5N/2JynAiIoVMlugmDnd/c2NU07 XhxTdjfWEZiFeOyE07BVOlU61DOfQPR4/oa5S/Wt7/F4DoUYFGEh+kaokHreHX8G8x82 Jd15y/EVd6CbRc07Hj//oX8/fHR3FHHGXPH0m79JMqj2HyphtrKKp+1d/4bgC9BTAQ2G K1B5EWpvoDSyFxagowOF6UP36xi11uRTcJznV8PhOZmGiud0CWHJPPFkvZykgq9drm9H witQ== X-Gm-Message-State: APjAAAVgPLntuzVkhCrzpEOYwPt4Dnn9jJWtP6YNEPFQP8O/fZcQ2bb6 6hlIe4gdKFEPVH+2APFqouSElHmjIao6mhgR6X/L9A== X-Google-Smtp-Source: APXvYqyWJE5HE5BPlxSpgDJzqZGWveLYGq4qZHWKEZKcOszWLNc7SCsVlg7veiJqwzeMOOaJbN8ggFQlcw7lmEu9Kmw= X-Received: by 2002:a05:620a:1393:: with SMTP id k19mr10972014qki.245.1552271064907; Sun, 10 Mar 2019 19:24:24 -0700 (PDT) MIME-Version: 1.0 References: <201903110127.x2B1R2as090886@repo.freebsd.org> <5c85c429.1c69fb81.1869f.e87bSMTPIN_ADDED_BROKEN@mx.google.com> In-Reply-To: <5c85c429.1c69fb81.1869f.e87bSMTPIN_ADDED_BROKEN@mx.google.com> From: Warner Losh Date: Sun, 10 Mar 2019 20:24:12 -0600 Message-ID: Subject: Re: svn commit: r344990 - in head: share/man/man9 sys/dev/ath sys/dev/bwi sys/dev/bwn sys/dev/ipw sys/dev/iwi sys/dev/iwm sys/dev/iwn sys/dev/malo sys/dev/mwl sys/dev/otus sys/dev/ral sys/dev/rtwn sys/... To: "Rodney W. Grimes" Cc: Andriy Voskoboinyk , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 8316D7363D X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=YASHFDu2 X-Spamd-Result: default: False [-5.46 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.01)[cached: ALT1.aspmx.l.google.com]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[b.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.70)[-0.703,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; IP_SCORE(-2.75)[ip: (-8.86), ipnet: 2607:f8b0::/32(-2.74), asn: 15169(-2.07), country: US(-0.07)]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2019 02:24:27 -0000 On Sun, Mar 10, 2019 at 8:12 PM Rodney W. Grimes wrote: > > Author: avos > > Date: Mon Mar 11 01:27:01 2019 > > New Revision: 344990 > > URL: https://svnweb.freebsd.org/changeset/base/344990 > > > > Log: > > Fix ieee80211_radiotap(9) usage in wireless drivers: > > > > - Alignment issues: > > * Add missing __packed attributes + padding across all drivers; in > > most places there was an assumption that padding will be always > > minimally suitable; in few places - e.g., in urtw(4) / rtwn(4) - > > padding was just missing. > > * Add __aligned(8) attribute for all Rx radiotap headers since they > can > > contain 64-bit TSF timestamp; it cannot appear in Tx radiotap headers, > so > > just drop the attribute here. Refresh ieee80211_radiotap(9) man page > > accordingly. > > > > - Since net80211 automatically updates channel frequency / flags in > > ieee80211_radiotap_chan_change() drop duplicate setup for these fields > > in drivers. > > > > Tested with Netgear WG111 v3 (urtw(4)), STA mode. > > > > MFC after: 2 weeks > > Isnt this going to seriously break module load compatibility > due to struct size and alignment changes if you merge this to stable/12? > It looks like all these changes are within the modules, not in the KBI... It looks like this will make things work better on architectures that don't like unaligned accesses. It seems like modules that aren't updated don't work today on those architectures... Warner > > Modified: > > head/share/man/man9/ieee80211_radiotap.9 > > head/sys/dev/ath/if_athioctl.h > > head/sys/dev/bwi/if_bwi.c > > head/sys/dev/bwi/if_bwivar.h > > head/sys/dev/bwn/if_bwn.c > > head/sys/dev/bwn/if_bwnvar.h > ... > > > -- > Rod Grimes > rgrimes@freebsd.org > >