From owner-freebsd-current Thu Feb 27 16:35:35 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id QAA27649 for current-outgoing; Thu, 27 Feb 1997 16:35:35 -0800 (PST) Received: from po1.glue.umd.edu (root@po1.glue.umd.edu [129.2.128.44]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id QAA27642 for ; Thu, 27 Feb 1997 16:35:30 -0800 (PST) Received: from uplink.eng.umd.edu (uplink.eng.umd.edu [129.2.98.181]) by po1.glue.umd.edu (8.8.5/8.8.5) with ESMTP id TAA02428 for ; Thu, 27 Feb 1997 19:35:21 -0500 (EST) Received: from localhost (chuckr@localhost) by uplink.eng.umd.edu (8.8.5/8.7.3) with SMTP id SAA27964 for ; Thu, 27 Feb 1997 18:21:02 -0500 (EST) X-Authentication-Warning: uplink.eng.umd.edu: chuckr owned process doing -bs Date: Thu, 27 Feb 1997 18:21:01 -0500 (EST) From: Chuck Robey X-Sender: chuckr@uplink.eng.umd.edu To: FreeBSD current Subject: fixing fsck Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk I was looking at fsck this morning (I had a few minutes before classes) and I immediately noticed two bugs. One was affecting the ufs mount stuff, where the ufsmount file needed to be included cause of the moved structs in it (ufs/ufs/ufsmount.h), but the other one was slightly more complicated. In dinode.h, all the time related fields, which used to be timespec structs (members tv_sec and tv_usec) are now int32_t, which doesn't have any logical connection to their time-related usage at all. I can't understand the reasoning behind this change. I easily enough made local changes here, changing the called out members, and doing the required casting, so that it would compile, but I haven't checked out all the possible builders of the field, to see if the field, which has changed size from being long X 2 to long X 1, is being correctly built. I can't understand the why behind this modification. If this change (which was done in the name of BSD-Litification, I guess) is going to stay for the sole reason of compatibility with BSD-Lite, I guess I'd continue the debugging, but I cna't see a good reason for this change, and I wonder if it's negotiable. To see what I'm talking about, cd to /sys/sys/ufs/ufs, and do a: cvs diff -r 1.4 dinode.h | less ----------------------------+----------------------------------------------- Chuck Robey | Interests include any kind of voice or data chuckr@eng.umd.edu | communications topic, C programming, and Unix. 9120 Edmonston Ct #302 | Greenbelt, MD 20770 | I run Journey2 and picnic, both FreeBSD (301) 220-2114 | version 3.0 current -- and great FUN! ----------------------------+-----------------------------------------------