From nobody Tue Jul 7 23:28:28 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gvy8Y19QLz6kCNH for ; Tue, 07 Jul 2026 23:28:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gvy8X5Rtxz3FS9 for ; Tue, 07 Jul 2026 23:28:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783466908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Va1f/RLSgpbAsg0JDDnd0zhK6kEjjycqnyo+tIrFL1k=; b=xihDZO66XXhnnjZy9/9ePWwmM3iv5vVBcRp6lNgwSllPaXhygaTbnuu0MkNobTV9T5TLnc 58FSWOs1Q9W5gFWhJxhQyMmPtKo+mZjSAsyVJu7BegcsTtsPGnN6WFiQqpy//jWkX5Jd6Q zA+Gouh8buWRkWIyN8ZLTcRUe0pL37Q7cNUe51brO5KUoJQz8GPCERLC94dquC9bEAARbv UWjIKXRMVsqhI5rbGWEjYfH00AD1wZ3kSQYdK/k3jURd7fSJfNEAsIZkHPvY6xsrquM0WS LcMbWJiWhqo4lZJ/4yh7sHP6euBI82b7vL+k1FOD6XRo0faynupTRNadqYwi7g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783466908; a=rsa-sha256; cv=none; b=IVK1i9eALHqNRcVB+HHwtUmEd0GYpJjhkUI6pdDGgHKaLs4/pgtjEDAm/RqH9sVb6MHcTy raPicQKd9nH1dUaUy24wi93IncZBUD02fFIgOyIf9IGBJWZBKfGKwSZrgYVyMtNT7rizVy jz2iPVKzraT204ydatR1VAUj2fucEkGK8ADgWiLt57NbtvKTGlchwvsAMKYTWzlT9eDk5d 2caS2PamvgjgLFc2LSHnvMeswQtbm97TzXSED96CrPlBKk3QCz0+Q47mXufOJB1vS6FWFU sVEDFMAewyGt4acD5y8GfP92SZ5fduAtcFQU6FvqFtKUFbxiaWPacZQMduTkMw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783466908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Va1f/RLSgpbAsg0JDDnd0zhK6kEjjycqnyo+tIrFL1k=; b=NGZMSg0t/2FdQfyQMJe17gF362tZht/C8QyUYHmeN5+p/kmZCDIRad0pzvOpCn3M/UDoq2 pgrImZexdqpl2uZXf/zR80BtxJYcbNOu5pd0QzOHeK3fe57LvWOLvY1+z2cUQ85r0b6GpV 4bTdjxrxjNZNI0PDfJdiK5F3zTmfmbhKgloGpISxuycMsGjU4ma6WgsfYq+dZzE1fSYmGH RPrzjjfeZHFosCNNkKW1AbFeTZHvug0439Zip+e6UQ0zg/R9XtcC3xco1Rc6NXGkkcvs9v PW9UF3y/g4ayhnzxl/EE4WliOX6N6E3O+KqUCbDB8VoGWIu5ueDymckdBzK9Hw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gvy8X4RzQzwL4 for ; Tue, 07 Jul 2026 23:28:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 31ccc by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 07 Jul 2026 23:28:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 23e94b040b9b - main - pddupfd(2): add basic test List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 23e94b040b9b99f097c113fc8576576ffec0486f Auto-Submitted: auto-generated Date: Tue, 07 Jul 2026 23:28:28 +0000 Message-Id: <6a4d8b9c.31ccc.231a4f86@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=23e94b040b9b99f097c113fc8576576ffec0486f commit 23e94b040b9b99f097c113fc8576576ffec0486f Author: Konstantin Belousov AuthorDate: 2026-07-07 05:49:54 +0000 Commit: Konstantin Belousov CommitDate: 2026-07-07 23:18:01 +0000 pddupfd(2): add basic test Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D57163 --- tests/sys/kern/procdesc.c | 74 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 74 insertions(+) diff --git a/tests/sys/kern/procdesc.c b/tests/sys/kern/procdesc.c index 388104054b82..541f15b49338 100644 --- a/tests/sys/kern/procdesc.c +++ b/tests/sys/kern/procdesc.c @@ -28,12 +28,14 @@ #include #include +#include #include #include #include #include #include #include +#include #include #include @@ -657,6 +659,76 @@ ATF_TC_BODY(pdopenpid_no_wakeup, tc) ATF_REQUIRE(close(fd) == 0); } +/* + * basic pddupfd functionality + */ + +#define EXPECTED_OFFSET 123 + +ATF_TC_WITHOUT_HEAD(pddupfd_basic); +ATF_TC_BODY(pddupfd_basic, tc) +{ + int *comm; + struct __wrusage wu; + struct __siginfo si; + int fd, pp, rfd, status, workfd, r, r1; + off_t off; + pid_t child; + + comm = mmap(NULL, sizeof(int), PROT_READ | PROT_WRITE, MAP_SHARED | + MAP_ANONYMOUS, -1, 0); + ATF_REQUIRE(comm != MAP_FAILED); + atomic_store_int(comm, -1); + + child = fork(); + ATF_REQUIRE(child != -1); + if (child == 0) { + workfd = open("/etc/passwd", O_RDONLY); + ATF_REQUIRE(workfd != -1); + atomic_store_int(comm, workfd); + while ((r = (int)atomic_load_int(comm)) >= 0) + sleep(1); + lseek(workfd, EXPECTED_OFFSET, SEEK_SET); + r -= 1; + atomic_store_int(comm, r); + while (r == (int)atomic_load_int(comm)) + sleep(1); + _exit(0x23); + } + + fd = pdopenpid(child, 0); + ATF_REQUIRE(fd != -1); + ATF_REQUIRE(pdgetpid(fd, &pp) == 0); + + while ((rfd = (int)atomic_load_int(comm)) == -1) + ; + ATF_REQUIRE(rfd >= 0); + workfd = pddupfd(fd, rfd, 0); + ATF_REQUIRE(workfd != -1); + + /* + * pddupfd-ed file must dup-ed, i.e. the underlying file must + * be same between the remote and local filedescriptors. + * Check that the initial seek offset is zero. Then observe + * the updated offset, which is only possible if the file is + * indeed shared. + */ + off = lseek(workfd, 0, SEEK_CUR); + ATF_REQUIRE_EQ(off, 0); + r = -1; + atomic_store_int(comm, r); + while ((r1 = (int)atomic_load_int(comm)) == r) + sleep(1); + off = lseek(workfd, 0, SEEK_CUR); + ATF_REQUIRE_EQ(off, EXPECTED_OFFSET); + r1 -= 1; + atomic_store_int(comm, r1); + ATF_REQUIRE(close(workfd) == 0); + + ATF_REQUIRE(pdwait(fd, &status, WEXITED, &wu, &si) != -1); + ATF_REQUIRE(close(fd) == 0); +} + ATF_TP_ADD_TCS(tp) { ATF_TP_ADD_TC(tp, pid_recycle); @@ -678,5 +750,7 @@ ATF_TP_ADD_TCS(tp) ATF_TP_ADD_TC(tp, pdopenpid_exiting); ATF_TP_ADD_TC(tp, pdopenpid_no_wakeup); + ATF_TP_ADD_TC(tp, pddupfd_basic); + return (atf_no_error()); }