From owner-svn-src-all@freebsd.org Fri Nov 15 01:07:20 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D6F841B7D2E; Fri, 15 Nov 2019 01:07:20 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47DgDl3p2Bz4NP2; Fri, 15 Nov 2019 01:07:19 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg1-x52d.google.com with SMTP id f19so4884813pgk.11; Thu, 14 Nov 2019 17:07:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=03mC4k1+/GOyMWLNHc0jfrtl1YIftyFr+2Rhv4AhuWY=; b=cpAhfmyFskhB6T4Xtc8Zu5rWsb7ymS1xlDEiSPQ/sbSSQNIJxztAGYRYZM6TEEwA8o 5yMZiS+ku8lF/4LebCqUJbFblUY1WhsUIIO9OOVmoVjtjzyW5UpHu8xeN4S5bq/SmwXd J19hPW3dMHtYClb7BK2M5PMQL1fwBwdMFpD7ZYXnA4u2vRCpwErQfOwDiTpBRjOXgbyI /AAK2HW3z318wbDsfvMnbm+5tL6WrzZES1pQNQyV962LKI5Bust6Qj1TOJAexccoVxjy 6sA2gm7SgrzB/YwWsxxYrRpQBv7BTovnjQF0d+usY8OZ7z26O7y4RT4ILLFUvkUETUIC hy9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=03mC4k1+/GOyMWLNHc0jfrtl1YIftyFr+2Rhv4AhuWY=; b=VEDvr9jUJQhWMMGWh5ECdLz+upvyHbeYihh0SHqjFZH4H5arDS9eRb4761GJRHPY7u ueD0/ye2jPnYAK4DWs0VPDGX/Ubcj0S3diBYsHpB+cqQm+6VaNCwgD8y/Pz1tmWmnzIJ 2rhFcne9jCTKp75DcLpXkABuFurOTQ2cOLxh5g88zRTAniFy/h8mxA1WDLLPTDko8ftB TZtdHfrzq80EfATOMOwKITNJuG59AaC3s1W2/Or3C20fe1Z0bK39agBWz4A84/66V52Z prArIMzU2ADOYG7qCPznAXIZHIMUpekG/3NggovtrgR5MqRu3HmmKW40k0XKNtUMWgoY vmYA== X-Gm-Message-State: APjAAAWYyryPHxe7AloHjPn3Nqsgmke7I4uRwZclK2KEbNew7fG0L4fT WqBKuAzApuZ9D/x5lv03/a6Xe9mu X-Google-Smtp-Source: APXvYqxct7sEJLEWgcD6v6NpHiGn+JfnagkCY/GL87h3WwQS9ELYR+vm5ti7+2OiKf5qFvn/SuYn9g== X-Received: by 2002:a17:90a:8401:: with SMTP id j1mr6079600pjn.39.1573780037162; Thu, 14 Nov 2019 17:07:17 -0800 (PST) Received: from [192.168.1.110] (180-150-68-130.b49644.syd.nbn.aussiebb.net. [180.150.68.130]) by smtp.gmail.com with ESMTPSA id x190sm9335597pfc.89.2019.11.14.17.07.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Nov 2019 17:07:16 -0800 (PST) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r354708 - head/sys/netinet/cc To: Michael Tuexen , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201911141628.xAEGS3QO052853@repo.freebsd.org> From: Kubilay Kocak Message-ID: <0a9e49e9-b81a-3367-2d7d-6d748e83f36d@FreeBSD.org> Date: Fri, 15 Nov 2019 12:07:13 +1100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Thunderbird/71.0 MIME-Version: 1.0 In-Reply-To: <201911141628.xAEGS3QO052853@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47DgDl3p2Bz4NP2 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=cpAhfmyF; dmarc=none; spf=pass (mx1.freebsd.org: domain of koobsfreebsd@gmail.com designates 2607:f8b0:4864:20::52d as permitted sender) smtp.mailfrom=koobsfreebsd@gmail.com X-Spamd-Result: default: False [-4.84 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[koobs@FreeBSD.org]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; FORGED_SENDER(0.30)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; IP_SCORE(-2.64)[ip: (-8.86), ipnet: 2607:f8b0::/32(-2.32), asn: 15169(-1.99), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FROM_NEQ_ENVFROM(0.00)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; TAGGED_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; RCVD_IN_DNSWL_NONE(0.00)[d.2.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Nov 2019 01:07:20 -0000 On 15/11/2019 3:28 am, Michael Tuexen wrote: > Author: tuexen > Date: Thu Nov 14 16:28:02 2019 > New Revision: 354708 > URL: https://svnweb.freebsd.org/changeset/base/354708 > > Log: > For idle TCP sessions using the CUBIC congestio control, reset ssthresh > to the higher of the previous ssthresh or 3/4 of the prior cwnd. > > Submitted by: Richard Scheffenegger > Reviewed by: Cheng Cui > Differential Revision: https://reviews.freebsd.org/D18982 > > Modified: > head/sys/netinet/cc/cc_cubic.c Are stable/12,11 affected by this too? > Modified: head/sys/netinet/cc/cc_cubic.c > ============================================================================== > --- head/sys/netinet/cc/cc_cubic.c Thu Nov 14 15:10:01 2019 (r354707) > +++ head/sys/netinet/cc/cc_cubic.c Thu Nov 14 16:28:02 2019 (r354708) > @@ -78,6 +78,7 @@ static int cubic_mod_init(void); > static void cubic_post_recovery(struct cc_var *ccv); > static void cubic_record_rtt(struct cc_var *ccv); > static void cubic_ssthresh_update(struct cc_var *ccv); > +static void cubic_after_idle(struct cc_var *ccv); > > struct cubic { > /* Cubic K in fixed point form with CUBIC_SHIFT worth of precision. */ > @@ -112,6 +113,7 @@ struct cc_algo cubic_cc_algo = { > .conn_init = cubic_conn_init, > .mod_init = cubic_mod_init, > .post_recovery = cubic_post_recovery, > + .after_idle = cubic_after_idle, > }; > > static void > @@ -192,7 +194,24 @@ cubic_ack_received(struct cc_var *ccv, uint16_t type) > } > } > > +/* > + * This is a Cubic specific implementation of after_idle. > + * - Reset cwnd by calling New Reno implementation of after_idle. > + * - Reset t_last_cong. > + */ > static void > +cubic_after_idle(struct cc_var *ccv) > +{ > + struct cubic *cubic_data; > + > + cubic_data = ccv->cc_data; > + > + newreno_cc_algo.after_idle(ccv); > + cubic_data->t_last_cong = ticks; > +} > + > + > +static void > cubic_cb_destroy(struct cc_var *ccv) > { > free(ccv->cc_data, M_CUBIC); > @@ -287,9 +306,6 @@ cubic_conn_init(struct cc_var *ccv) > static int > cubic_mod_init(void) > { > - > - cubic_cc_algo.after_idle = newreno_cc_algo.after_idle; > - > return (0); > } > > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >