Date: Tue, 10 Jul 2018 11:16:23 +0100 From: Edward Napierala <trasz@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r474290 - in head/lang: . cbmbasic Message-ID: <CAFLM3-q%2BYaW1tLE11rs7M1fymVxxC1OabAk0ZMeVvaCKs-Of0A@mail.gmail.com> In-Reply-To: <20180710084509.y4he7wfeffjgthdy@atuin.in.mat.cc> References: <201807091935.w69JZYtN013948@repo.freebsd.org> <20180709224236.v42i6ha5rcvplqsm@atuin.in.mat.cc> <CAFLM3-o5Ry2L2Xt0SejBh5VQ4qD=mk%2BkCtURh%2Bi828RPD3pv2Q@mail.gmail.com> <20180710084509.y4he7wfeffjgthdy@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
2018-07-10 9:45 GMT+01:00 Mathieu Arnold <mat@freebsd.org>: > On Tue, Jul 10, 2018 at 12:31:12AM +0100, Edward Napierala wrote: > > 2018-07-09 23:42 GMT+01:00 Mathieu Arnold <mat@freebsd.org>: > > > > > On Mon, Jul 09, 2018 at 07:35:34PM +0000, Edward Tomasz Napierala > wrote: > > > > +PORTVERSION= 20180708 > > > > + > > > > +GH_ACCOUNT= mist64 > > > > +GH_TAGNAME= 89093eba090d6e1c2d2b6e1cb1616dba0ce9c7f6 > > > > + > > > > > > The 20180708 version seems wrong. When upstream does not have > versions, > > > please do not "invent" one. Please read this to learn how to deal with > > > those case: > > > > > > https://www.freebsd.org/doc/en/books/porters-handbook/ > > > makefile-distfiles.html#makefile-master_sites-github-ex4 > > > > > > Thanks, I didn't know that. Should I just directly change that, or do I > > also > > need to bump PORTREVISION? > > It depends on how you will update it. If you switch to using gYYYYMMDD, > then you would need to bu PORTEPOCH as the version wold go backwards. > It is probably not needed in this case as upstream has not seen an > update in four years and probably will never get a release, but please > do keep it in mind the next time you want to invent a version. > Ah, ok. Again, thanks for explaining this.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFLM3-q%2BYaW1tLE11rs7M1fymVxxC1OabAk0ZMeVvaCKs-Of0A>