Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Aug 2012 14:13:34 GMT
From:      Alberto Villa <avilla@FreeBSD.org>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/170669: [patch] devel/subversion: fix build when WITHOUT_NLS and WITH_KDE_KWALLET are defined
Message-ID:  <201208161413.q7GEDYoY002682@red.freebsd.org>
Resent-Message-ID: <201208161420.q7GEK6Ej051471@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         170669
>Category:       ports
>Synopsis:       [patch] devel/subversion: fix build when WITHOUT_NLS and WITH_KDE_KWALLET are defined
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 16 14:20:06 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Alberto Villa
>Release:        
>Organization:
>Environment:
>Description:
`make configure` fails in devel/subversion when WITHOUT_NLS and WITH_KDE_KWALLET are defined, with:

checking whether to look for KWallet... yes
configure: error: missing support for internationalization
===>  Script "configure" failed unexpectedly.

kwallet.m4 reveals that NLS support is required by KWallet.
>How-To-Repeat:
make configure -C /usr/ports/devel/subversion -DWITHOUT_NLS -DWITH_KDE_KWALLET
>Fix:
The attached patch forces NLS support to be built also when WITH_KDE_KWALLET is defined.

Patch attached with submission follows:

Index: Makefile.common
===================================================================
--- Makefile.common	(revision 302485)
+++ Makefile.common	(working copy)
@@ -132,7 +132,8 @@
 LIB_DEPENDS+=	svn_client-1:${PORTSDIR}/devel/subversion
 .endif
 
-.if !defined(WITHOUT_NLS)
+# KWallet requires NLS to be enabled.
+.if !defined(WITHOUT_NLS) || defined(WITH_KDE_KWALLET)
 USE_GETTEXT=	yes
 PLIST_SUB+=	WITHOUT_GETTEXT=""
 .else


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201208161413.q7GEDYoY002682>