From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Aug 16 14:20:07 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 61C161065675 for ; Thu, 16 Aug 2012 14:20:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2073C8FC1D for ; Thu, 16 Aug 2012 14:20:07 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q7GEK6mm051472 for ; Thu, 16 Aug 2012 14:20:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q7GEK6Ej051471; Thu, 16 Aug 2012 14:20:06 GMT (envelope-from gnats) Resent-Date: Thu, 16 Aug 2012 14:20:06 GMT Resent-Message-Id: <201208161420.q7GEK6Ej051471@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alberto Villa Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 323A71065672 for ; Thu, 16 Aug 2012 14:13:35 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 1DE6B8FC08 for ; Thu, 16 Aug 2012 14:13:35 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q7GEDYe9002683 for ; Thu, 16 Aug 2012 14:13:34 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q7GEDYoY002682; Thu, 16 Aug 2012 14:13:34 GMT (envelope-from nobody) Message-Id: <201208161413.q7GEDYoY002682@red.freebsd.org> Date: Thu, 16 Aug 2012 14:13:34 GMT From: Alberto Villa To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/170669: [patch] devel/subversion: fix build when WITHOUT_NLS and WITH_KDE_KWALLET are defined X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2012 14:20:07 -0000 >Number: 170669 >Category: ports >Synopsis: [patch] devel/subversion: fix build when WITHOUT_NLS and WITH_KDE_KWALLET are defined >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Aug 16 14:20:06 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Alberto Villa >Release: >Organization: >Environment: >Description: `make configure` fails in devel/subversion when WITHOUT_NLS and WITH_KDE_KWALLET are defined, with: checking whether to look for KWallet... yes configure: error: missing support for internationalization ===> Script "configure" failed unexpectedly. kwallet.m4 reveals that NLS support is required by KWallet. >How-To-Repeat: make configure -C /usr/ports/devel/subversion -DWITHOUT_NLS -DWITH_KDE_KWALLET >Fix: The attached patch forces NLS support to be built also when WITH_KDE_KWALLET is defined. Patch attached with submission follows: Index: Makefile.common =================================================================== --- Makefile.common (revision 302485) +++ Makefile.common (working copy) @@ -132,7 +132,8 @@ LIB_DEPENDS+= svn_client-1:${PORTSDIR}/devel/subversion .endif -.if !defined(WITHOUT_NLS) +# KWallet requires NLS to be enabled. +.if !defined(WITHOUT_NLS) || defined(WITH_KDE_KWALLET) USE_GETTEXT= yes PLIST_SUB+= WITHOUT_GETTEXT="" .else >Release-Note: >Audit-Trail: >Unformatted: