From owner-freebsd-stable@FreeBSD.ORG  Thu Sep  1 08:12:09 2011
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C78FE1065673;
	Thu,  1 Sep 2011 08:12:09 +0000 (UTC)
	(envelope-from trent@snakebite.org)
Received: from exchange.liveoffice.com (exchla3.liveoffice.com [64.70.67.188])
	by mx1.freebsd.org (Postfix) with ESMTP id A6B9F8FC1F;
	Thu,  1 Sep 2011 08:12:09 +0000 (UTC)
Received: from EXHUB02.exchhosting.com (192.168.11.214) by
	exhub05.exchhosting.com (192.168.11.101) with Microsoft SMTP Server
	(TLS) id 8.2.213.0; Thu, 1 Sep 2011 01:02:03 -0700
Received: from EXMBX10.exchhosting.com ([fe80::8133:164f:2c4b:a631]) by
	exhub02.exchhosting.com ([fe80::311c:a4c3:90a7:3e53%12]) with mapi;
	Thu, 1 Sep 2011 01:02:03 -0700
From: Trent Nelson <trent@snakebite.org>
To: Attilio Rao <attilio@freebsd.org>
Date: Thu, 1 Sep 2011 01:02:01 -0700
Thread-Topic: panic: spin lock held too long (RELENG_8 from today)
Thread-Index: AcxofW6hUUYoIy6/RxOeU8HldTJ4aQ==
Message-ID: <363D7137-CC1E-45F6-927C-98201BCDF397@snakebite.org>
References: <20110818.091600.831954331552558249.hrs@allbsd.org>
	<CAJ-FndCL70m41dQ9FPmzUg0V8a9JacvLOnjmMQL=3PfN7NmPfQ@mail.gmail.com>
	<20110818025550.GA1971@libertas.local.camdensoftware.com>
	<20110819.092811.1087267565626420460.hrs@allbsd.org>
	<20110819003759.GC54831@libertas.local.camdensoftware.com>
	<4E4E5D49.4040502@sentex.net>
	<CAJ-FndDHmwa+=LNGgU+5MK2Xmtj8kWHB10JsoytkMGEtVgncYw@mail.gmail.com>
In-Reply-To: <CAJ-FndDHmwa+=LNGgU+5MK2Xmtj8kWHB10JsoytkMGEtVgncYw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "freebsd-stable@freebsd.org" <freebsd-stable@freebsd.org>
Subject: Re: panic: spin lock held too long (RELENG_8 from today)
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Sep 2011 08:12:09 -0000


On Aug 19, 2011, at 7:53 PM, Attilio Rao wrote:

> If nobody complains about it earlier, I'll propose the patch to re@ in 8 =
hours.

Just a friendly 'me too', for the records.  22 hours of heavy network/disk =
I/O and no panic yet -- prior to the patch it was a panic orgy.

Any response from re@ on the patch?  It didn't appear to be in stable/8 as =
of yesterday:

[root@flanker/ttypts/0(../src/sys/kern)#] svn diff
Index: kern_timeout.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- kern_timeout.c	(revision 225280)
+++ kern_timeout.c	(working copy)
@@ -268,9 +268,11 @@
 	CC_LOCK_ASSERT(cc);
=20
 	c->c_cpu =3D CPUBLOCK;
+	spinlock_enter();
 	CC_UNLOCK(cc);
 	new_cc =3D CC_CPU(new_cpu);
 	CC_LOCK(new_cc);
+	spinlock_exit();
 	c->c_cpu =3D new_cpu;
 	return (new_cc);
 }


Regards,

	Trent.=