From owner-freebsd-testing@FreeBSD.ORG Sun Mar 2 21:14:51 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D4F3A920 for ; Sun, 2 Mar 2014 21:14:51 +0000 (UTC) Received: from mail-qa0-f49.google.com (mail-qa0-f49.google.com [209.85.216.49]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9146419AC for ; Sun, 2 Mar 2014 21:14:51 +0000 (UTC) Received: by mail-qa0-f49.google.com with SMTP id cm18so519114qab.36 for ; Sun, 02 Mar 2014 13:14:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=Y9E8bP61uPJu+5w+BjTu09mNDJ0gg2oHR5exZqyAMc8=; b=BI5Ur2dsbLimkIIwf/Q7GdhqUtg/fjDVAswAJcpfiHOaK0z/JYAp6Nryw66rKCSRYc JirH8MyGzRnYsiSZzuiKu9mt0f8Dlcju/FEDdd+ZA0VL/V1bZEjC7v3sy4L6rKehl8ok QowNRpPZHOc0uGV88NU2BVspPZFLmWVx0i7+j4KhYFdxxMnjlfc7583lbC7XPXZ5r1d4 biLA3Lrtclf1Je0SPzu9KDi96lCf9acvVf1gPAy9v4se2p0Htn36C7MqzhYpv5fCFu8Q 9PdATY/Z6LGTmEKSTJ/wQoRO3pMwgCJBGKRDuebzkCWM9cZbjMLHRf/raxSd7ThCyQyO UoPw== X-Gm-Message-State: ALoCoQkEr0MlFoznwzKMN83XfZBmxVgKQtxKJJAT3EvdL57JMMXp5tPFsaHcACamO72XuY5wk/tX X-Received: by 10.224.157.7 with SMTP id z7mr19057801qaw.37.1393794890471; Sun, 02 Mar 2014 13:14:50 -0800 (PST) MIME-Version: 1.0 Sender: jmmv@meroh.net Received: by 10.96.83.102 with HTTP; Sun, 2 Mar 2014 13:14:30 -0800 (PST) X-Originating-IP: [108.176.158.82] In-Reply-To: <96373EF8-77EA-4AA6-8422-63881C32E455@gmail.com> References: <20140124162759.GB90996@stack.nl> <0A68C9FE-6A3A-4DCF-92A9-A506D7581D69@gmail.com> <96373EF8-77EA-4AA6-8422-63881C32E455@gmail.com> From: Julio Merino Date: Sun, 2 Mar 2014 16:14:30 -0500 X-Google-Sender-Auth: bOJUH1iPhqq4WoYggs4CoKijLfo Message-ID: Subject: Re: [PATCH v2] convert /bin/sh tests over to ATF To: Garrett Cooper Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-testing@freebsd.org" , Jilles Tjoelker X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Mar 2014 21:14:51 -0000 On Mon, Jan 27, 2014 at 5:02 AM, Garrett Cooper wrote: > Hi all, > Here's the next patch for converting bin/sh/tests over to ATF. I've tried to incorporate all input from folks about simplifying the integration scripts and removing valid_osreldate functionality. Apologies for the really long delay... I suppose nothing has changed given that there were no replies to this. Soooo, some more comments: * Could functional_test be created with ATF_TESTS_SH ? * Rename the script in subversion to functional_test.sh (including the extension). * Do NOT cd out of the current work directory in functional_test, anywhere. This breaks all the assumptions in tests regarding the ability to write to the current work directory without caring about cleaning up. * Use atf_get_srcdir to locate where the data files are, not dirname $0. * Continue to use SUBDIR, not ATF_TESTS_SUBDIRS. The latter does not exist. * Reintroduce $FreeBSD$ to functional_test.sh. * The empty Makefiles in all the subdirectories are quite confusing. At the very least, explicitly define TESTSDIR as is customary everywhere else. * I'm still afraid of all this "auto-discovery" of test cases based on files, because it is quite confusing... but at least it's now a bit more self-contained and easier to strip out later. So we could keep it. * The FILES must continue to be installed. Does this actually work when running your test programs after a "make install"? Cheers