From owner-freebsd-current Fri Mar 29 20:26:55 2002 Delivered-To: freebsd-current@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id E19B437B400 for ; Fri, 29 Mar 2002 20:26:50 -0800 (PST) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.2/8.12.2) with ESMTP id g2U4QmYm058215; Fri, 29 Mar 2002 20:26:48 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.2/8.12.2/Submit) id g2U4PXoS039757; Fri, 29 Mar 2002 20:25:33 -0800 (PST) Date: Fri, 29 Mar 2002 20:25:33 -0800 From: "David O'Brien" To: Alexander Leidinger Cc: winter@jurai.net, freebsd-current@FreeBSD.org Subject: Re: cvs commit: ports/lang Makefile ports/lang/icc Makefile distinfo pkg-comment pkg-descr pkg-plist ports/lang/icc/files patch-include Message-ID: <20020329202533.B74181@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <20020328181725.I45452-100000@sasami.jurai.net> <200203291044.g2TAi6h8000665@Magelan.Leidinger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200203291044.g2TAi6h8000665@Magelan.Leidinger.net>; from Alexander@Leidinger.net on Fri, Mar 29, 2002 at 11:44:06AM +0100 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Mar 29, 2002 at 11:44:06AM +0100, Alexander Leidinger wrote: > > My patches to src/share/mk/ are here: > > > > ftp://ftp.jurai.net/users/winter/icc.mk.diff > > > > This allows you to set 'USE_ICC' and 'ICFLAGS' and build stuff. This is fine just to get things working. But please consider Doing It Right -- that being wrap the definitions of CC, CFLAGS, and PICFLAG with USE_ICC rather than strew USE_ICC all over the place. For instance: /usr/share/mk/sys.mk .if defined(USE_ICC) CC= icc .else CC= cc .endif > > -D__ICC__=1 > > ICC already defines '__ICC', doe we really need this? I see no reason for it. We should use the vendor's spelling for identifying their compiler. > > -D__attribute__(x)= > > -D__GNUC__=2 > > Ok as a short term solution, but IMHO this should get solved in the > source. Totally agreed for defining __GNUC__. -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message