Date: Sat, 31 Oct 2020 15:56:33 -0600 From: Warner Losh <imp@bsdimp.com> To: Mateusz Guzik <mjguzik@gmail.com> Cc: Brandon Bergren <bdragon@freebsd.org>, Brandon Bergren <bdragon@imap.cc>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r367229 - in head/sys/contrib/openzfs: include/sys/zstd module/zstd Message-ID: <CANCZdfqkt33twLDJ0H=c7bGF2agfS4S6Z4DROYZwdemH%2BndnGQ@mail.gmail.com> In-Reply-To: <CAGudoHHc-UP%2BX1GcqJ6Ri407r1cGuZs2WPqg8dAWwHT-pfBY=Q@mail.gmail.com> References: <202010311907.09VJ7WcY036325@repo.freebsd.org> <7b9e157c-9b8e-4a0e-b3f6-38edbfebf005@www.fastmail.com> <CAGudoHFXAiobCwFgiNUj9UNRShNO1FctjsfS5w8xaWc%2B--d-gg@mail.gmail.com> <d5618cc3-3b0c-4c39-909e-863bd2f30de3@www.fastmail.com> <540675c8-35bb-40a7-b947-73f31a72bff2@www.fastmail.com> <ac03dc12-4bfa-43db-abbf-44da355823e2@www.fastmail.com> <CAGudoHHc-UP%2BX1GcqJ6Ri407r1cGuZs2WPqg8dAWwHT-pfBY=Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Go for it. Warner On Sat, Oct 31, 2020, 2:57 PM Mateusz Guzik <mjguzik@gmail.com> wrote: > I agree. Please commit. > > On 10/31/20, Brandon Bergren <bdragon@freebsd.org> wrote: > > Yeah, that is what was happening. The minimal implementation needed for > > libsa was missing. > > > > On Sat, Oct 31, 2020, at 3:33 PM, Brandon Bergren wrote: > >> Maybe this is it?: > >> > >> Index: sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h > >> =================================================================== > >> --- sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h (revision > >> 367230) > >> +++ sys/contrib/openzfs/include/os/freebsd/spl/sys/atomic.h (working > >> copy) > >> @@ -188,6 +188,8 @@ > >> */ > >> #undef atomic_add_64 > >> #define atomic_add_64(ptr, val) *(ptr) += val > >> +#undef atomic_sub_64 > >> +#define atomic_sub_64(ptr, val) *(ptr) -= val > >> #endif /* !_STANDALONE */ > >> > >> #endif /* !_OPENSOLARIS_SYS_ATOMIC_H_ */ > >> > >> > >> Note that there is also another build failure in the tree at the moment. > >> > >> On Sat, Oct 31, 2020, at 3:25 PM, Brandon Bergren wrote: > >> > Actually, looking at it again, it looks like the spl header is doing > it > >> > > >> > wrong and not providing a fallback for atomic_sub_64, it's just > >> > defining it to atomic_subtract_64 and assuming that exists. > >> > > >> > On Sat, Oct 31, 2020, at 3:23 PM, Mateusz Guzik wrote: > >> > > Yep, jenkins told me. Working on it. > >> > > > >> > > On 10/31/20, Brandon Bergren <bdragon@freebsd.org> wrote: > >> > > > This doesn't compile on platforms such as powerpc without pulling > in > >> > > > the > >> > > > opensolaris atomics header from the spl that does locking > emulation > >> > > > of 64 > >> > > > bit atomics, as platforms that don't have native 64 bit atomics do > >> > > > not > >> > > > provide them in the system header. > >> > > >> > >> -- > >> Brandon Bergren > >> bdragon@imap.cc > >> > > > > -- > > Brandon Bergren > > bdragon@FreeBSD.org > > > > > -- > Mateusz Guzik <mjguzik gmail.com> >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqkt33twLDJ0H=c7bGF2agfS4S6Z4DROYZwdemH%2BndnGQ>