From nobody Sat Jun 6 16:49:36 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gXkmh0RRtz6g1NK; Sat, 06 Jun 2026 16:49:40 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gXkmg6BbYz3gDH; Sat, 06 Jun 2026 16:49:39 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780764579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s7Ypy1MA0RHpTY2POohEiDIQdhYgElXm926Vlj4FAs4=; b=VcVaDH2JbTA5SVxyRd3oFwPfd0esP5jUQQtOYjV9stSCH1/5rB/+m5/9WM7p5xZz4SP94h lFkHjgBmBre1uubLj9bX0lpYX77QRTR3GfJHJfjYNhaxm5hNOawGHvHNDrvFqGsOVvoKup qKL9Y51llyX99fmc6C6fk8MrCxPfNjzaauVK1HvAS0CdifIc0LzZYajaiBU1h4Zml1YMCc aoCDLygn9/6Nk0PDLJ2JLvi4aDaVsYYURUwzSTWyn7RWALSOO0/REPgBfL0JFwFGfZqcqL iECQMSKWelJaNvDyuGVTnTbt0qf3A7s1a3MIxZJsiFb+FxYT2jtRpOWy4NAR3g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780764579; a=rsa-sha256; cv=none; b=PNgzZU8ynuwhXoejFHbOtrFRdiEbbRx6K1uKQagED5WMG9O8PM7AxzwqsLzNKezQCaqRCs kezEb57hcbfYVhG3Xlf+6LFKNFO8Sp0oaD17rXoXm22pcOFRdpb03/q+GXQl5DWhnT7DfV Ws92HjX1v0rU/lpSCClmFXQ8zEqb2A4OyFJWwVm4/OddZY9dtT6qzHLqapJ50KyK+o41A4 UM38H2TXodd1O8s/3zZ00DcYmavNtRrpovJMZ8npwFxrQwR6Sdu2s+AQZIN/k12Q0/zyDU 8PmEE0onMvdUfe1zLX+exgYcppqupoKP8tqLSjawszEysPFpZlu0PYtV5XguZQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780764579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s7Ypy1MA0RHpTY2POohEiDIQdhYgElXm926Vlj4FAs4=; b=C2hMlJVwVB6tE5cbs/23MSEqw1XVe8TYrMr+KEebF59ooUD87bY3JCF0Cq3umsILHPU3Pe CenM+BvitYGxDhMhkDB4V/Wlq/EGW9/SoRpTYwMUFE9OZTSYcQqkoojZHG/auL5l7RYDr9 yWA9872fS19CzTf9fvV1kWJ4YeZpHrE5NaMA3gujY4S3W7IQMY0YWm98V/5G6uGTuzyqNg P2Ylekjoyyxavy8ZRXoSagCSj8jrGCwTdpU5sCzmn3hrz3T2e+JWG6DJo45DYxJoG7riq7 ZIx70NaSicbPxlYmESL3JhSr0U0DvAUsb5iAEqXSGDM7fNgnFmjn3jEnqMVrug== Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E7" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gXkmg4hfLz1FJS; Sat, 06 Jun 2026 16:49:39 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 42B06A64805; Sat, 06 Jun 2026 16:49:12 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 11D9E2D029E9; Sat, 6 Jun 2026 16:49:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id iyYAJdeOxY5f; Sat, 6 Jun 2026 16:49:37 +0000 (UTC) Received: from nv.t4-02.sbone.de (nv.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id E63402D029D8; Sat, 6 Jun 2026 16:49:36 +0000 (UTC) Date: Sat, 6 Jun 2026 16:49:36 +0000 (UTC) From: "Bjoern A. Zeeb" To: Warner Losh cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 3915ffb1c3e0 - main - loader.efi: Fix when staging moves late In-Reply-To: <6a23770c.38eb9.20880b83@gitrepo.freebsd.org> Message-ID: <48s4sp9p-3r66-9886-2455-32n94407qrs@mnoonqbm.arg> References: <6a23770c.38eb9.20880b83@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Sat, 6 Jun 2026, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3915ffb1c3e04b26d1506bf35d3f665b2e25a915 > > commit 3915ffb1c3e04b26d1506bf35d3f665b2e25a915 > Author: Warner Losh > AuthorDate: 2026-06-05 05:18:40 +0000 > Commit: Warner Losh > CommitDate: 2026-06-06 01:24:42 +0000 > > loader.efi: Fix when staging moves late > > Prior to this commit, we'd compute the page tables and have the last > entries point to the staging area. We'd then add some more metadata to > the image and boot. This assumed the staging area didn't need to move > for this last bit of data. > > However, if we go over the staging limit, when we copyin new data, we > grow the staging area, usually be moving it to a lower address. This > overage usually happens when we're loading modules and so things work > out nicely. Sometimes we're close to the limit, and we need to do this > growing inside bi_load, after we've computed the page table, making the > page table wrong, and the code we jump to random rather than the btext > routine we normally start at. > > To fix this, move computation of the table (but not its allocation) to > after bi_load, but before we call the trampoline. > > This problem was most observed when loading microcode for many peole, > but Gleb reproduced the error with a set of modules that didn't include > ucode. I looked through the PR (not all of it) and I have seen little explanations of how this bug was observed as a user, as in how far did the boot process get (possibly with beasty disabled). The reason I am asking is that I am wondering if the various occasions where people in the last years have seen "Booting [/boot/kernel/kernel]...", possibly "Loading splash ok" but never saw the boot marker "---<>---" (or any things in between) anymore could have been the same bug? > PR: 294630 > Reviewed by: kib (prior version) > Sponsored by: Netflix > MFC After: insta per re@ request > Differential Revision: https://reviews.freebsd.org/D57462 -- Bjoern A. Zeeb r15:7