From nobody Wed Sep 6 21:57:00 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rgx6h6gQQz4sJ84; Wed, 6 Sep 2023 21:57:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rgx6h5Lltz3cQy; Wed, 6 Sep 2023 21:57:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694037420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ld1Ap1Zh2PtfsLiQr+QRx8mKf54uFlczrF4/gRjwVOc=; b=ROw7e9Wy+eucLgVqZANkTBpYW+vzyoSJBzU1p+MrkLN8vdRaUJ53zfrhVkHp0WcVn1X4HU EHjhTvK9jESyi+YaSX8tecGZ/UrxFLujNeUSmYEVpyJPRGhx0tiFncjdRcWsdKL9nrzvFT tPs/i9d7O//sUuGQCfVUrMJf7X1VGxp0hG5zhul8mmOlfbcV4sxrye2Cnkap92Vo6jJzTn fw5/4lylpU9WVnsfCxo7oKPMUlJBsA9Z5z5M48sQM6NT5octBdh3iGHbiljK10sr0c3jOO CuAVDsMTcwhyyKN74+fPpSJ4xgQUdE9ACCfMKKvrk9oUTFCI/owdPOZspKc1rg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694037420; a=rsa-sha256; cv=none; b=F2T/cVixjugTArhAvDYxXA8hLdW+TtB6z0xGrcb72tXzdT7L/d1DY2Z55CbFDTjU2cUXhn ZBPT5WvTeynluVYbvl6qaOcwlsPdBgfP1n9+IDAurSYT6HXzs6dsq0epuJ+xBWVSAQtydK cbeKT/sReNutDvmP3gHQAVmMsj0i2N7zCMm/hN72kNbWYgSTLE+2nQaIACQne+liO/LQS6 QFc9vclXPg/rpHwGL+AzuQF419MhnMUsSE5xAQWNrWLAPrO/RMIaNJpqbl3+lHQfLt9Xqp ns1k9vXckIJYfGYsNN9NriiU8s2CSX6plpwdmociIZ1b4jNUiuhMfjSJ5P09+A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694037420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ld1Ap1Zh2PtfsLiQr+QRx8mKf54uFlczrF4/gRjwVOc=; b=OQrToXkQCR6fy8OY2RvgPBtWbYjdYmF8HnkTaseibsQFIB2P/Br7OTK3TFMS+cJ8tJoF0U AEA+rcOnkuKWd0LFqxmFScAf3sl5wpqu9A3ka4abih7zPbHE/tWRRnZcQEYa/VfgZ3JjpJ PhdT7+DI5uFTSgWDDSe2ggLz//g4n2EA7Otx3C8WlGLMyhBBvIbVKmt7NCS43s16lqJfDY h7Ti8JsWNvG7Ksj6Croe86nCtlRpJ3ztZ5CmUKwyauk3NjGoQW61ycoMfWQ3umzh0yGd33 4Oa7OVjMwNneWA/b4S4AxwcL+TsThNZz9a6L3z/+sqPBf5u58TcMIZbTaZyu5w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rgx6h4Q44zZ4w; Wed, 6 Sep 2023 21:57:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 386Lv0Ng023622; Wed, 6 Sep 2023 21:57:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 386Lv08g023619; Wed, 6 Sep 2023 21:57:00 GMT (envelope-from git) Date: Wed, 6 Sep 2023 21:57:00 GMT Message-Id: <202309062157.386Lv08g023619@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: f9c32827759b - stable/12 - libpfctl: Don't pass stack garbage to free. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: f9c32827759b2e1dda97d91f69d70673f5c9393b Auto-Submitted: auto-generated The branch stable/12 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=f9c32827759b2e1dda97d91f69d70673f5c9393b commit f9c32827759b2e1dda97d91f69d70673f5c9393b Author: John Baldwin AuthorDate: 2023-03-22 19:33:59 +0000 Commit: John Baldwin CommitDate: 2023-09-06 20:02:00 +0000 libpfctl: Don't pass stack garbage to free. GCC 9 on stable/12 reports a -Wmaybe-uninitialized error for the call to free in _pfctl_clear_states. Reviewed by: mjg Differential Revision: https://reviews.freebsd.org/D39198 (cherry picked from commit 48c519be0e8005aedc817b1bc1101ad32b67a67a) --- lib/libpfctl/libpfctl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/libpfctl/libpfctl.c b/lib/libpfctl/libpfctl.c index a095cdd1e54b..8917ee166473 100644 --- a/lib/libpfctl/libpfctl.c +++ b/lib/libpfctl/libpfctl.c @@ -923,7 +923,6 @@ static int _pfctl_clear_states(int dev, const struct pfctl_kill *kill, unsigned int *killed, uint64_t ioctlval) { - struct pfioc_nv nv; nvlist_t *nvl; int ret; @@ -946,7 +945,6 @@ _pfctl_clear_states(int dev, const struct pfctl_kill *kill, *killed = nvlist_get_number(nvl, "killed"); nvlist_destroy(nvl); - free(nv.data); return (ret); }