From owner-freebsd-bugs@FreeBSD.ORG Thu Jul 29 09:30:08 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7B3641065676 for ; Thu, 29 Jul 2010 09:30:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3EBCA8FC13 for ; Thu, 29 Jul 2010 09:30:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o6T9U8dV024595 for ; Thu, 29 Jul 2010 09:30:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o6T9U8MB024594; Thu, 29 Jul 2010 09:30:08 GMT (envelope-from gnats) Resent-Date: Thu, 29 Jul 2010 09:30:08 GMT Resent-Message-Id: <201007290930.o6T9U8MB024594@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Petr Lampa` Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 48CE8106566B for ; Thu, 29 Jul 2010 09:27:52 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 385AC8FC25 for ; Thu, 29 Jul 2010 09:27:52 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o6T9RpFB000245 for ; Thu, 29 Jul 2010 09:27:51 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o6T9Rp89000244; Thu, 29 Jul 2010 09:27:51 GMT (envelope-from nobody) Message-Id: <201007290927.o6T9Rp89000244@www.freebsd.org> Date: Thu, 29 Jul 2010 09:27:51 GMT From: Petr Lampa` To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/149059: regression in /etc/rc.subr X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jul 2010 09:30:08 -0000 >Number: 149059 >Category: misc >Synopsis: regression in /etc/rc.subr >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jul 29 09:30:07 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Petr Lampa` >Release: STABLE-8.1 >Organization: BUT FIT >Environment: FreeBSD XXX 8.1-STABLE FreeBSD 8.1-STABLE #2: Wed Jul 28 15:00:35 CEST 2010 root@XXX:/usr/src/sys/i386/compile/XXX i386 >Description: The last change in /etc/rc.subr broke sendmail startup with sendmail_enable="NONE". We start sendmail in our local script, after this change, MTA daemon from /etc/rc.d/sendmail is started, too. We don't want two sendmail daemons in one system :-( See http://www.freebsd.org/cgi/cvsweb.cgi/src/etc/rc.subr.diff?r1=1.88.2.10;r2=1.88.2.11;f=h In our case $rc_pid contains pid of locally started sendmail, so this case in run_rc_command is now false: if [ -n "${rcvar}" -a "$rc_arg" != "rcvar" -a -z "${rc_pid}" ]; if ! checkyesno ${rcvar}; then if [ -n "${rc_quiet}" ]; then return 0 fi fi fi The checkyesno is not executed and the script doesn't return through return 0 as it was returning before this change. I really don't understand why the test for rc_pid was added here and the CVS comment doesn't help too much: SVN rev 207797 on 2010-05-08 21:18:22Z by dougb MFC r206686: Make 'stop' work even if ${name}_enable is not set. >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted: