From owner-svn-src-all@FreeBSD.ORG Sat Oct 12 07:26:50 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id ECAF25B7; Sat, 12 Oct 2013 07:26:50 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from smtpauth3.wiscmail.wisc.edu (wmauth3.doit.wisc.edu [144.92.197.226]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E66F12E78; Sat, 12 Oct 2013 07:26:49 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from avs-daemon.smtpauth3.wiscmail.wisc.edu by smtpauth3.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) id <0MUJ00M00O8GBY00@smtpauth3.wiscmail.wisc.edu>; Sat, 12 Oct 2013 02:26:49 -0500 (CDT) X-Spam-PmxInfo: Server=avs-3, Version=6.0.3.2322014, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.10.12.70914, SenderIP=0.0.0.0 X-Spam-Report: AuthenticatedSender=yes, SenderIP=0.0.0.0 Received: from wanderer.tachypleus.net (dhcp-138-246-50-110.dynamic.eduroam.mwn.de [138.246.50.110]) by smtpauth3.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) with ESMTPSA id <0MUJ009N3OOJ5310@smtpauth3.wiscmail.wisc.edu>; Sat, 12 Oct 2013 02:26:47 -0500 (CDT) Message-id: <5258F9B3.7030101@freebsd.org> Date: Sat, 12 Oct 2013 09:26:43 +0200 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.0 To: Devin Teske , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r256343 - in head/usr.sbin/bsdinstall: . scripts References: <201310112041.r9BKfZeT002056@svn.freebsd.org> In-reply-to: <201310112041.r9BKfZeT002056@svn.freebsd.org> X-Enigmail-Version: 1.5.2 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Oct 2013 07:26:51 -0000 On 10/11/13 22:41, Devin Teske wrote: > Author: dteske > Date: Fri Oct 11 20:41:35 2013 > New Revision: 256343 > URL: http://svnweb.freebsd.org/changeset/base/256343 > > Log: > Add zfsboot module as an option for automatic configuration. Default is > to run interactively but it can be scripted too (optinally completely > non-interactive). Currently supports GELI and all ZFS vdev types. Also > performs validation on selections/settings providing error messages if > necessary, explaining (in plain language) what the issue is. Currently > the auto partitioning of naked disks only supports GPT and MBR (VTOC8 > pending for sparc64), so is only available for i386/amd64 install. > > Submitted by: Allan Jude , myself > Reviewed by: Allan Jude > Approved by: re (glebius) Hi Devin -- As was discussed on the mailing list, this patch still has some issues that need to be resolved, for example the use of camcontrol unconditionally even when the disks may not be CAM and destruction of existing sub-partitioning for MBR disks. There were some others brought up in the discussion as well. I am surprised you committed it, especially to stable/10, before those issues were resolved. I'm also not sure if people can review their own patches. Installer regressions are very easy to introduce and very problematic when created. Real review for installer changes is thus especially important this late in the release cycle. Do you have any plans to fix these issues in the very near future? -Nathan