Date: Tue, 13 May 2003 11:10:11 -0700 (PDT) From: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/52173: bsd.port.mk - Modify USE_GETOPT_LONG option when Message-ID: <200305131810.h4DIABU7020275@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/52173; it has been noted by GNATS.
From: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org>
To: Tilman Linneweh <tilman@arved.de>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: ports/52173: bsd.port.mk - Modify USE_GETOPT_LONG option when
Date: Tue, 13 May 2003 15:06:36 -0300
Updated patch with arved's catch.
Do you propose that we always define CPPFLAGS and LDFLAGS?
And use them as MAKE_ENV if not GNU_CONFIGURE?
Isn't CFLAGS more appropriate then CPPFLAGS when we don't have
GNU_CONFIGURE?
--- With arved's catch
--- bsd.port.mk.orig Tue May 6 03:46:16 2003
+++ bsd.port.mk Tue May 13 15:03:01 2003
@@ -1271,7 +1271,11 @@
LIB_DEPENDS+= gnugetopt.1:${PORTSDIR}/devel/libgnugetopt
CPPFLAGS+= -I${LOCALBASE}/include
LDFLAGS+= -L${LOCALBASE}/lib -lgnugetopt
+.if defined(GNU_CONFIGURE)
CONFIGURE_ENV+= CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
+.else
+MAKE_ENV+= CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
+.endif
.endif
.endif
--- Using CFLAGS's idea (still not sure about it)
--- bsd.port.mk.orig Tue May 6 03:46:16 2003
+++ bsd.port.mk Tue May 13 15:06:11 2003
@@ -1269,9 +1269,14 @@
.if defined(USE_GETOPT_LONG)
.if ${OSVERSION} < 500041
LIB_DEPENDS+= gnugetopt.1:${PORTSDIR}/devel/libgnugetopt
-CPPFLAGS+= -I${LOCALBASE}/include
LDFLAGS+= -L${LOCALBASE}/lib -lgnugetopt
+.if defined(GNU_CONFIGURE)
+CPPFLAGS+= -I${LOCALBASE}/include
CONFIGURE_ENV+= CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
+.else
+CFLAGS+= -I${LOCALBASE}/include
+MAKE_ENV+= CFLAGS="${CFLAGS}" LDFLAGS="${LDFLAGS}"
+.endif
.endif
.endif
--
Mario S F Ferreira - DF - Brazil - "I guess this is a signature."
FreeBSD Committer | CS Developer
flames to beloved devnull@someotherworldbeloworabove.org
feature, n: a documented bug | bug, n: an undocumented feature
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200305131810.h4DIABU7020275>