From owner-cvs-all Thu Sep 13 19:32:41 2001 Delivered-To: cvs-all@freebsd.org Received: from lists.unixathome.org (lists.unixathome.org [210.48.103.158]) by hub.freebsd.org (Postfix) with ESMTP id DB80E37B407; Thu, 13 Sep 2001 19:32:33 -0700 (PDT) Received: from wocker (lists.unixathome.org [210.48.103.158]) by lists.unixathome.org (8.11.1/8.11.1) with ESMTP id f8E2WOZ81638; Fri, 14 Sep 2001 14:32:25 +1200 (NZST) (envelope-from dan@langille.org) From: "Dan Langille" Organization: novice in training To: Josef Karthauser Date: Thu, 13 Sep 2001 22:32:16 -0400 MIME-Version: 1.0 Subject: Re: Proposed patch to log_accum.pl Reply-To: dan@langille.org Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <3BA133F0.17179.75B20696@localhost> In-reply-to: <20010914022811.E28588@tao.org.uk> X-mailer: Pegasus Mail for Win32 (v4.0, beta 40) Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7BIT Content-description: Mail message body Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 14 Sep 2001 at 2:28, Josef Karthauser wrote: > I've attached a patch to CVSROOT/log_accum.pl that I'd like comments on > before I commit it. > > At the moment we get a summary line for each modified file in the commit > email, i.e.: > > Revision Changes Path > 1.108 +6 -5 src/sys/kern/kern_descrip.c > > The attached patch caused us to also get these lines for added and > removed files. I like that idea, from a FreshPorts II point of view. One of the technical problems is tracking which version of a file has been deleted. Having the above helps greatly. A more important item, from a FreshPorts II point of view is the path name is often incomplete. That is, the first directory is often omitted. A few example from recent commits: Added files: biology/tinker/files tview Removed files: biology/tinker/files patch-ag Added files: usr.sbin/kldxref Makefile ef.c ef.h fileformat kldxref.8 kldxref.c The logistics of determining the actual directory prefix is a bit beyond hard. It would be simplified by a log entry such as: Added files: ports/biology/tinker/files tview Added files: src/usr.sbin/kldxref Is such a change within the bounds of reason? > It's been suggested that the revision number be followed > with "(dead)" in the case of removed files. Is this necessary? Not for me. -- Dan Langille - DVL Software Limited The FreeBSD Diary - http://freebsddiary.org/ - practical examples To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message