From owner-svn-src-head@FreeBSD.ORG  Fri Feb 27 07:48:19 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 59D68106564A;
	Fri, 27 Feb 2009 07:48:17 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail11.syd.optusnet.com.au (mail11.syd.optusnet.com.au
	[211.29.132.192])
	by mx1.freebsd.org (Postfix) with ESMTP id C83458FC12;
	Fri, 27 Feb 2009 07:48:16 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from c122-107-120-227.carlnfd1.nsw.optusnet.com.au
	(c122-107-120-227.carlnfd1.nsw.optusnet.com.au [122.107.120.227])
	by mail11.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	n1R7mBrL019494
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 27 Feb 2009 18:48:13 +1100
Date: Fri, 27 Feb 2009 18:48:11 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@delplex.bde.org
To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
In-Reply-To: <20090226232352.S53478@maildrop.int.zabbadoz.net>
Message-ID: <20090227184405.Q13337@delplex.bde.org>
References: <200902261212.n1QCCYI6027315@svn.freebsd.org>
	<20090226232352.S53478@maildrop.int.zabbadoz.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, Ed Schouten <ed@FreeBSD.org>
Subject: Re: svn commit: r189066 - head/sys/kern
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Feb 2009 07:48:20 -0000

On Thu, 26 Feb 2009, Bjoern A. Zeeb wrote:

> On Thu, 26 Feb 2009, Ed Schouten wrote:
>> Log:
>>  Remove redundant assignment of `p'.
>> 
>>  `p' is already initialized with `td->td_proc'. Because td is always
>>  curthread, it is safe to initialize it without any locks.
>> 
>>  Found by:	LLVM's scan-build
>> 
>> Modified:
>>  head/sys/kern/subr_prf.c
>> 
>> Modified: head/sys/kern/subr_prf.c
>> ==============================================================================
>> --- head/sys/kern/subr_prf.c	Thu Feb 26 12:06:46 2009	(r189065)
>> +++ head/sys/kern/subr_prf.c	Thu Feb 26 12:12:34 2009	(r189066)
>> @@ -137,7 +137,6 @@ uprintf(const char *fmt, ...)
>> 		return (0);
>> 
>> 	sx_slock(&proctree_lock);
>> -	p = td->td_proc;
>> 	PROC_LOCK(p);
>> 	if ((p->p_flag & P_CONTROLT) == 0) {
>> 		PROC_UNLOCK(p);
>
>
> I think this one is wrong. You should probably have removed the
> assignment from declaration time as we are checking for td != NULL
> just above that so it could possibly be a NULL pointer deref in the
> initial assigment or the NULL check is redundant.

Almost all of them are wrong, since they keep the assignment with the
style bug (initialization in declaration) and remove the one without
the style bug.  In libkern this also increases the divergence from the
libc versions, since the libc versions are missing the style bug.

Bruce