Date: Mon, 31 May 2021 07:09:10 +0000 From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 255473] Infinite writes on UFS with SU+J filesystem Message-ID: <bug-255473-3630-LRxtsZSYUi@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-255473-3630@https.bugs.freebsd.org/bugzilla/> References: <bug-255473-3630@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255473 --- Comment #37 from Jack <xxjack12xx@gmail.com> --- Created attachment 225399 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D225399&action= =3Dedit Unable to disable journal on softupdates after applying patch I'm still unable to turn off journaling with the patch. root@upstairs:/usr/src # git diff diff --git a/sys/ufs/ffs/ffs_softdep.c b/sys/ufs/ffs/ffs_softdep.c index 2cc16ab2a2c1..cc3f64b4e70e 100644 --- a/sys/ufs/ffs/ffs_softdep.c +++ b/sys/ufs/ffs/ffs_softdep.c @@ -2653,6 +2653,10 @@ softdep_uninitialize() callout_drain(&softdep_callout); } +static int enable_suj =3D 0; +SYSCTL_INT(_debug_softdep, OID_AUTO, enable_suj, CTLFLAG_RW, + &enable_suj, 0, "Enable the activation of journaled soft updates"); + /* * Called at mount time to notify the dependency code that a * filesystem wishes to use it. @@ -2716,7 +2720,7 @@ softdep_mount(devvp, mp, fs, cred) ACQUIRE_GBLLOCK(&lk); TAILQ_INSERT_TAIL(&softdepmounts, sdp, sd_next); FREE_GBLLOCK(&lk); - if ((fs->fs_flags & FS_SUJ) && + if (enable_suj && (fs->fs_flags & FS_SUJ) && (error =3D journal_mount(mp, fs, cred)) !=3D 0) { printf("Failed to start journal: %d\n", error); softdep_unmount(mp); root@upstairs:/usr/src # uname -a FreeBSD upstairs.jack.com 13.0-STABLE FreeBSD 13.0-STABLE #0 stable/13-n245805-4a4a174959ce-dirty: Sun May 30 23:31:47 PDT 2021=20=20=20= =20 jack@upstairs.jack.com:/usr/obj/usr/src/amd64.amd64/sys/UPSTAIRS amd64 --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-255473-3630-LRxtsZSYUi>