From owner-freebsd-perl@FreeBSD.ORG  Wed Oct  5 14:51:06 2005
Return-Path: <owner-freebsd-perl@FreeBSD.ORG>
X-Original-To: perl@FreeBSD.org
Delivered-To: freebsd-perl@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3BF6816A41F;
	Wed,  5 Oct 2005 14:51:06 +0000 (GMT) (envelope-from tobez@tobez.org)
Received: from heechee.tobez.org (heechee.tobez.org [217.157.39.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A657B43D49;
	Wed,  5 Oct 2005 14:51:04 +0000 (GMT) (envelope-from tobez@tobez.org)
Received: by heechee.tobez.org (Postfix, from userid 1001)
	id A2BAA125420; Wed,  5 Oct 2005 16:51:03 +0200 (CEST)
Date: Wed, 5 Oct 2005 16:51:03 +0200
From: Anton Berezin <tobez@tobez.org>
To: Volker Stolz <vs@FreeBSD.org>
Message-ID: <20051005145103.GB75014@heechee.tobez.org>
References: <20051005144811.GL55946@i2.informatik.rwth-aachen.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20051005144811.GL55946@i2.informatik.rwth-aachen.de>
X-Powered-By: FreeBSD http://www.freebsd.org/
User-Agent: Mutt/1.5.11
Cc: perl@FreeBSD.org, leeym@FreeBSD.org
Subject: Re: p5-Mail-SpamAssassin and versioned BUILD_DEPS, please review
X-BeenThere: freebsd-perl@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: maintainer of a number of perl-related ports
	<freebsd-perl.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-perl>,
	<mailto:freebsd-perl-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-perl>
List-Post: <mailto:freebsd-perl@freebsd.org>
List-Help: <mailto:freebsd-perl-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-perl>,
	<mailto:freebsd-perl-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Oct 2005 14:51:06 -0000

On Wed, Oct 05, 2005 at 04:48:11PM +0200, Volker Stolz wrote:
> I know that you should always update all pre-requisites for a port, but this
> one seems to be a good start to introduce versioned dependencies since I actually
> got bitten by this on one of my hosts :)
> 
> Please review!

Looks fine - except - pardon my ignorance - but does it really,
definitely require Net::DNS 0.53 and not anything below it?

> Index: Makefile
> ===================================================================
> RCS file: /usr/freebsdcvs/cvs-ports/ports/mail/p5-Mail-SpamAssassin/Makefile,v
> retrieving revision 1.81
> diff -u -u -r1.81 Makefile
> --- Makefile	30 Sep 2005 00:31:51 -0000	1.81
> +++ Makefile	5 Oct 2005 14:37:05 -0000
> @@ -17,7 +17,7 @@
>  MAINTAINER=	perl@FreeBSD.org
>  COMMENT=	A highly efficient mail filter for identifying spam
>  
> -BUILD_DEPENDS=	${SITE_PERL}/${PERL_ARCH}/Net/DNS.pm:${PORTSDIR}/dns/p5-Net-DNS \
> +BUILD_DEPENDS=	p5-Net-DNS>=0.53:${PORTSDIR}/dns/p5-Net-DNS \
>  		${SITE_PERL}/${PERL_ARCH}/HTML/Parser.pm:${PORTSDIR}/www/p5-HTML-Parser \
>  		${SITE_PERL}/Mail/Internet.pm:${PORTSDIR}/mail/p5-Mail-Tools
>  RUN_DEPENDS=	${BUILD_DEPENDS}

\Anton.
-- 
An undefined problem has an infinite number of solutions.
-- Robert A. Humphrey