From owner-freebsd-fs@FreeBSD.ORG Wed Aug 6 14:00:03 2008 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2BC621065671 for ; Wed, 6 Aug 2008 14:00:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 16EEF8FC15 for ; Wed, 6 Aug 2008 14:00:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m76E02Vg034823 for ; Wed, 6 Aug 2008 14:00:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m76E028t034822; Wed, 6 Aug 2008 14:00:02 GMT (envelope-from gnats) Date: Wed, 6 Aug 2008 14:00:02 GMT Message-Id: <200808061400.m76E028t034822@freefall.freebsd.org> To: freebsd-fs@FreeBSD.org From: "Mateusz Guzik" Cc: Subject: Re: kern/126287: [ufs] [panic] Kernel panics while mounting an UFS filesystem with snapshot enabled X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Mateusz Guzik List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Aug 2008 14:00:03 -0000 The following reply was made to PR kern/126287; it has been noted by GNATS. From: "Mateusz Guzik" To: "Kostik Belousov" Cc: freebsd-fs@freebsd.org, bug-followup@freebsd.org Subject: Re: kern/126287: [ufs] [panic] Kernel panics while mounting an UFS filesystem with snapshot enabled Date: Wed, 6 Aug 2008 15:52:24 +0200 2008/8/6 Kostik Belousov : > On Wed, Aug 06, 2008 at 10:20:05AM +0000, Mateusz Guzik wrote: >> The following reply was made to PR kern/126287; it has been noted by GNATS. >> >> From: "Mateusz Guzik" >> To: bug-followup@freebsd.org >> Cc: >> Subject: Re: kern/126287: [ufs] [panic] Kernel panics while mounting an UFS filesystem with snapshot enabled >> Date: Wed, 6 Aug 2008 12:15:00 +0200 >> >> Something weird happened to my attachment, I'll paste it here: >> >> --- sys/kern/vfs_mount.c.orig 2008-08-06 11:14:16.000000000 +0200 >> +++ sys/kern/vfs_mount.c 2008-08-06 11:14:32.000000000 +0200 >> @@ -196,10 +196,13 @@ >> void >> vfs_deleteopt(struct vfsoptlist *opts, const char *name) >> { >> struct vfsopt *opt, *temp; >> >> + if (opts == NULL) >> + return; >> + >> TAILQ_FOREACH_SAFE(opt, opts, link, temp) { >> if (strcmp(opt->name, name) == 0) >> vfs_freeopt(opts, opt); >> } >> } >> >> Again, it should work fine ;) > > The PR lacks the backtrace (preferrable the ddb output or "bt full" from > kgdb) for the panic. Please, show me the backtrace. > Sorry, I don't have currently access to fbsd 7, so here is backtrace from CURRENT(crashed by mount -o snapshot /somefilesystem): [..] #11 0xc06e1e5b in calltrap () at /srv/build/CURRENT/src/sys/i386/i386/exception.s:165 #12 0xc05c86d4 in vfs_deleteopt (opts=0x0, name=0xc074ef52 "snapshot") at /srv/build/CURRENT/src/sys/kern/vfs_mount.c:195 #13 0xc068d689 in ffs_mount (mp=0xc29f52a0, td=0xc2875af0) at /srv/build/CURRENT/src/sys/ufs/ffs/ffs_vfsops.c:172 #14 0xc05cb1d8 in vfs_donmount (td=0xc2875af0, fsflags=0, fsoptions=0xc261db80) at /srv/build/CURRENT/src/sys/kern/vfs_mount.c:1010 #15 0xc05cc3bb in nmount (td=0xc2875af0, uap=0xcd3a7cf8) at /srv/build/CURRENT/src/sys/kern/vfs_mount.c:417 #16 0xc06f9157 in syscall (frame=0xcd3a7d38) at /srv/build/CURRENT/src/sys/i386/i386/trap.c:1081 #17 0xc06e1ef0 in Xint0x80_syscall () at /srv/build/CURRENT/src/sys/i386/i386/exception.s:261 Thanks, -- Mateusz Guzik