From owner-freebsd-gecko@FreeBSD.ORG Fri Sep 6 14:46:42 2013 Return-Path: Delivered-To: gecko@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 21731B87 for ; Fri, 6 Sep 2013 14:46:42 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id F1C50227D for ; Fri, 6 Sep 2013 14:46:41 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id E7724B96B for ; Fri, 6 Sep 2013 10:46:40 -0400 (EDT) From: John Baldwin To: gecko@freebsd.org Subject: www/firefox broken if DEBUG is enabled Date: Fri, 6 Sep 2013 10:21:54 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p28; KDE/4.5.5; amd64; ; ) MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201309061021.54959.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 06 Sep 2013 10:46:41 -0400 (EDT) X-BeenThere: freebsd-gecko@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Gecko Rendering Engine issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Sep 2013 14:46:42 -0000 Compile error is: /usr/ports/www/firefox/work/mozilla-release/netwerk/wifi/nsWifiScannerFreeBSD.cpp:127:13: error: invalid operands to binary expression ('const char *' and 'const char *') << "SSID: " << ssid << ", " ^ ~~~~~~~~ ../../../netwerk/wifi/nsWifiMonitor.h:27:61: note: expanded from macro 'LOG' #define LOG(args) PR_LOG(gWifiMonitorLog, PR_LOG_DEBUG, args) ^ /usr/local/include/nspr/prlog.h:178:19: note: expanded from macro 'PR_LOG' PR_LogPrint _args; \ ^ 1 error generated. If you look at the the prlog.h header, you can see that PR_LOG() expects to get printf-style args, but the code in nsWifiScannerFreeBSD.cpp is trying to use C++ iostreams: + // log the data + LOG(( "FreeBSD access point: " + << "SSID: " << ssid << ", " + << "MAC: " << isr->isr_bssid << ", " + << "Strength: " << isr->isr_rssi ", " + << "Channel: " << isr->isr_freq << "MHz" )); (This code is in files/patch-bug893397 in the port.) I think the fix is to just change this to use printf style, but I punted and built firefox without debugging for now. This should likely be fixed upstream as well (if not already). -- John Baldwin