From owner-svn-ports-head@FreeBSD.ORG Tue Jun 11 17:00:32 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 4E03D4DB; Tue, 11 Jun 2013 17:00:32 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-we0-x230.google.com (mail-we0-x230.google.com [IPv6:2a00:1450:400c:c03::230]) by mx1.freebsd.org (Postfix) with ESMTP id 610391EE9; Tue, 11 Jun 2013 17:00:31 +0000 (UTC) Received: by mail-we0-f176.google.com with SMTP id t56so5958625wes.7 for ; Tue, 11 Jun 2013 10:00:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=cBjo3gmEZAZWVCB2ZtRZIOb76hDkb071tBtYLw1Y7P0=; b=i9gqw9k7tsYvJMxqDP63rODSHKV6hxn44bCa9GN7rS2y/dyJuMH3z69rWAMTQY3DK2 SPQATm5hR1jIxVw1V+PlLYeQoHETdAuHqXn1V97RZ93jpOSeoAdRS9TS9LEbp/ncTywI 4jsHDxsCAVi12NhmmTXbxsXIXvAFebq+h35OJFK+S/NK0d4jMXHnmcJkNEXOl9rEIAxZ v1YQcIKGiL2Kxesq7+6k0wsAR8QL8inMeANDte2eIDmwdTKIZ5ix/PeOkdINTl3R/72L 33SWQPgU5OFJyx5P1KfOk77G6JMMKRI1UpIZea5CzqgDqIkVu2rBEDrycQmJKP/1AKFo S7Qw== X-Received: by 10.180.182.229 with SMTP id eh5mr1909753wic.63.1370970030510; Tue, 11 Jun 2013 10:00:30 -0700 (PDT) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id x13sm18921232wib.3.2013.06.11.10.00.29 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 11 Jun 2013 10:00:29 -0700 (PDT) Sender: Baptiste Daroussin Date: Tue, 11 Jun 2013 19:00:27 +0200 From: Baptiste Daroussin To: Eitan Adler Subject: Re: svn commit: r320546 - in head/devel: . tradcpp tradcpp/files Message-ID: <20130611170026.GE35160@ithaqua.etoilebsd.net> References: <201306111055.r5BAtHmb094470@svn.freebsd.org> <20130611164037.GD35160@ithaqua.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/T5/D81aE6hAEKcd" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jun 2013 17:00:32 -0000 --/T5/D81aE6hAEKcd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 11, 2013 at 06:48:34PM +0200, Eitan Adler wrote: > On Tue, Jun 11, 2013 at 6:40 PM, Baptiste Daroussin wr= ote: > > No patching is better, has I'm heavily working with upstream on this po= rt. > > > > In general disable warning is something I don't like, I prefer to fix t= hem, and > > I don't find that complexify the port at all. >=20 > I've found patching software often leads to introducing subtle bugs: > its incredibly annoying trying to track down a bug only to determine > that is is a distro patch. Also, it makes it more difficult for the > reader of the patch to figure out why the patch is there: > it increases the mental effort before "oh, maintainer is just working > around compiler warnings" >=20 > That said, this isn't a strong feeling. I know exactly what I'm doing and why, I know why I do patch, and I'm worki= ng as said in the previous mail directly with upstream (those patches are now integrated in better vesions). I think I have enough experience in the ports tree to decide if I should pa= tch or not my own ports. bapt, --/T5/D81aE6hAEKcd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlG3V6oACgkQ8kTtMUmk6EzqXACgvr5LbhNfX+os7/6kypBSCGih 1GEAn2F7TEGjKb8CZ3iUbjevqDT6yAWD =rafH -----END PGP SIGNATURE----- --/T5/D81aE6hAEKcd--