From owner-svn-src-head@freebsd.org Fri Dec 30 02:00:43 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1D1F5C97546; Fri, 30 Dec 2016 02:00:43 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from st11p00im-asmtp003.me.com (st11p00im-asmtp003.me.com [17.172.80.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E96EF15D1; Fri, 30 Dec 2016 02:00:42 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from process-dkim-sign-daemon.st11p00im-asmtp003.me.com by st11p00im-asmtp003.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) id <0OIZ0050041U0Z00@st11p00im-asmtp003.me.com>; Fri, 30 Dec 2016 00:59:26 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mac.com; s=4d515a; t=1483059566; bh=nfna8saqi11VWLLv4lqG21xac7TWPsR5WFKEMqhuXF0=; h=Date:Subject:From:To:Message-id:MIME-version:Content-type; b=mqx0/Ln1SQuuqXSSESW7BA/6OTHkqBFuKvSoxBr3E3Z1vILaMhq95Ft15wNoX0SER zDGhBj8KTIixyykbi7NZ5BqXNkj99RkjzV7KypvKIgzRZYJuqKgAD8gYrRERdB0v29 2+joYAko+yNspO+4gnfM8sXd/9nVbWZevnOTEe++xIjvwIQaxuzidz0yPYnsfjdxrX dfRx2uFIvHyghycVuCO6Sh9MyZdt5SJ71+KaesM0C77hu8O2MEcx0NRaBBHuehw+9e Aq9PYtLbR4rVpgIRyR+TqCsKv0GTwCV/HZf54Eqmmn0/bX7KF4vX7faDEYt84L32sw idshNlav3H7tw== Received: from [10.0.0.7] (c-73-6-177-70.hsd1.tx.comcast.net [73.6.177.70]) by st11p00im-asmtp003.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) with ESMTPSA id <0OIZ0001542XGK10@st11p00im-asmtp003.me.com>; Fri, 30 Dec 2016 00:59:25 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-29_19:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1034 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1603290000 definitions=main-1612300013 User-Agent: Microsoft-MacOutlook/f.1d.0.161209 Date: Thu, 29 Dec 2016 18:59:17 -0600 Subject: Re: svn commit: r310789 - head/lib/libpam/static_libpam From: Ravi Pokala Sender: "Pokala, Ravi" To: Alexander Kabaev , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-id: <1A7F0D4F-1F4D-4885-B7E9-F764D4FA72BF@panasas.com> Thread-topic: svn commit: r310789 - head/lib/libpam/static_libpam References: <201612292130.uBTLUqus011628@repo.freebsd.org> In-reply-to: <201612292130.uBTLUqus011628@repo.freebsd.org> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Dec 2016 02:00:43 -0000 Hi Alexander, I'm a little confused - the original version had to have had a compile-only step to generate the object first, before running the link-only operation against the object. The new code replaces the link-only operation with a compile+link operation. Shouldn't the pre-existing compile-only operation be removed, since the new compile+link operation supersedes it? Thanks, Ravi (rpokala@) -----Original Message----- > From: on behalf of Alexander Kabaev > Date: 2016-12-29, Thursday at 15:30 > To: , , > Subject: svn commit: r310789 - head/lib/libpam/static_libpam > > Author: kan > Date: Thu Dec 29 21:30:52 2016 > New Revision: 310789 > URL: https://svnweb.freebsd.org/changeset/base/310789 > > Log: > Use compiler driver to build relocatable object > > This works better with external toolchains where LD > will not necessarily defailt to emulation we want. > Compiler driver knows better. > > Modified: > head/lib/libpam/static_libpam/Makefile > > Modified: head/lib/libpam/static_libpam/Makefile > ============================================================================== > --- head/lib/libpam/static_libpam/Makefile Thu Dec 29 21:06:31 2016 (r310788) > +++ head/lib/libpam/static_libpam/Makefile Thu Dec 29 21:30:52 2016 (r310789) > @@ -64,6 +64,6 @@ CLEANFILES+= openpam_static.o \ > openpam_static_modules.o > > openpam_static_modules.o: openpam_static.o ${STATIC_MODULES} > - ${LD} -o ${.TARGET} -r --whole-archive ${.ALLSRC} > + ${CC} -nostdlib ${CFLAGS} -o ${.TARGET} -r -Wl,--whole-archive ${.ALLSRC} > > .include "${.CURDIR}/../libpam/Makefile"