From nobody Sun Sep 1 17:14:50 2024 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxdmV5kPGz5Mcb7 for ; Sun, 01 Sep 2024 17:14:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxdmV4cXsz4nL9 for ; Sun, 1 Sep 2024 17:14:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725210890; a=rsa-sha256; cv=none; b=ICexnRYjE33h7inMtNY4Leg5eB7tmOcEvAbiOB8ynezoHxx+b643+AHcySipIwBW5P9pF/ BFAbTEiM01ErWnK+BOCWwdhfgwAZs/1u2tDDpXAYuwHuDt5O0QvtktwDZXHaudR3SxsBEn sf4ndN8rrIgK5X9zThP09p0YUrkLdl3+fNgGyVkb33ai67Nn5zyXJaYgqOQXmW+5iG2NiN uD0ye6d1u2D+VI6dgF/HQcJb6Aj7qSBPaFneE7nhqFxvhbyn4p4Ar/J1q3DxZ7yZKxHDza IEwuAS453x7DU75Oq2c/EiskVM89pbiWPC5NGzbxq9crnfiee08bv/xDNhVuDA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725210890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=e5SASyGbDvEOupvYTdZTAXCPJVdX8W3DQHU0qHnwfZE=; b=Ht4nLmJz5Kevywyy0et25hvv0WU5zkyLEfnbkkVEvWIhbtmxzxY1VlbcDsu3W2Hmcok5xs EL02Q6QlZaUsohzRt8w2qlSqKWuqFCJ6/xB/KQ1g0/z3YBUY4xxQmihkoo+19JVBWhKqRi LkOcmLhmamKcew830oa8y5uG29s3ZcMtRbO4D++Qy+aLfngYOtWQI9FiCyxbeYE+Pr9huj mBx36eEvtRjoYf6Vfm+gnCdw5Qqtq7FmsV6dHmFvnAt0vzv3/jFbK4Ep5cxY+XwqUdNNLH ix0QU8kUpSGRi0DMhTuhHflYOqGFlenzLDDT64WwlrVQoSuUl24ZCzjfj1YvVQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxdmV45YQzdJ1 for ; Sun, 1 Sep 2024 17:14:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 481HEo9Q059182 for ; Sun, 1 Sep 2024 17:14:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 481HEowb059181 for ports-bugs@FreeBSD.org; Sun, 1 Sep 2024 17:14:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 281193] devel/rapidfuzz-cpp: fix tests with libc++ 19 Date: Sun, 01 Sep 2024 17:14:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: dim@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: yuri@freebsd.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports-bugs@freebsd.org Sender: owner-freebsd-ports-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D281193 Bug ID: 281193 Summary: devel/rapidfuzz-cpp: fix tests with libc++ 19 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: yuri@freebsd.org Reporter: dim@FreeBSD.org Assignee: yuri@freebsd.org Flags: maintainer-feedback?(yuri@freebsd.org) As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes ports using devel/rapidfuzz-cpp to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ =20=20=20 /wrkdirs/usr/ports/devel/py-rapidfuzz/work-py311/rapidfuzz-3.9.6/src/rapidf= uzz/cpp_common.hpp:711:25: note: in instantiation of template class 'std::basic_string' requested here 711 | auto proc_str =3D rf::opcodes_apply(ops, s1, = s2); | ^ The devel/rapidfuzz-cpp port itself does "build" since it only gathers a bunch of headers and installs them into the stage area, but running 'make test' also fails similarly: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undef= ined template 'std::char_traits' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ =20 /wrkdirs/usr/ports/devel/rapidfuzz-cpp/work/rapidfuzz-cpp-3.0.5/test/distan= ce/examples/ocr.cpp:3:28: note: in instantiation of template class 'std::basic_string' requested here 3 | std::basic_string ocr_example1 =3D { | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ Unfortunately rapidfuzz-cpp makes heavy use of the no-longer-existing `std::basic_string`, so I had to do quite a lots of search and replace operations, replacing these with equivalent `std::vector` types. Note that as far as I can see, only devel/py-rapidfuzz is a consumer of this port, applying these changes should not disrupt anything else. I have a follow-up patch for that port too. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals --=20 You are receiving this mail because: You are the assignee for the bug.=