Date: Thu, 24 May 2007 13:23:49 -0500 From: Stephen Montgomery-Smith <stephen@math.missouri.edu> To: Joe Marcus Clarke <marcus@marcuscom.com> Cc: gnome@freebsd.org, pav@freebsd.org, freebsd-ports@freebsd.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: More speed increases for make-ing ports Message-ID: <4655D835.3080709@math.missouri.edu> In-Reply-To: <1180023393.10757.29.camel@shumai.marcuscom.com> References: <465291FB.4010901@math.missouri.edu> <20070522071941.GB59910@xor.obsecurity.org> <4652FFB4.8060107@math.missouri.edu> <1179846295.52353.27.camel@pav.hide.vol.cz> <4653349D.7080608@math.missouri.edu> <46533D66.1070305@math.missouri.edu> <1179868612.83498.6.camel@ikaros.oook.cz> <1179869940.83498.9.camel@ikaros.oook.cz> <20070522165525.S52261@math.missouri.edu> <1179871899.83498.10.camel@ikaros.oook.cz> <20070522172627.A52261@math.missouri.edu> <465398E0.40404@math.missouri.edu> <1179907804.60308.1.camel@pav.hide.vol.cz> <4654E491.5000700@math.missouri.edu> <1179995317.66903.17.camel@pav.hide.vol.cz> <46558678.3020704@math.missouri.edu> <1180023393.10757.29.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Joe Marcus Clarke wrote: > On Thu, 2007-05-24 at 07:35 -0500, Stephen Montgomery-Smith wrote: >> Pav Lucistnik wrote: >>> Stephen Montgomery-Smith píše v st 23. 05. 2007 v 20:04 -0500: >>> >>>> I'm getting kind of uncomfortable with the patch. I looked some more >>>> in >>>> bsd.gnome.mk and it seems to me that the suggested patch is really >>>> equivalent to the patch enclosed here. >>>> >>>> Why did the writer of bsd.gnome.mk have the rather complicated >>>> construction which I am proposing to replace? >>> I don't know, we'd have to ask Joe Marcus. Here is the revision in >>> question: >>> >>> http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.gnome.mk.diff?r1=1.22;r2=1.23 >>> >>> You're basically reverting that revision. Perhaps our make(1) wasn't >>> smart enough those four years ago, I don't know. >> I'm not really reverting that revision. As it was prior to that >> revision, I can see it not working under many circumstances. Namely, if >> ${component} appears more than once in ${_USE_GNOME} - something that >> will happen frequently - the test will not work. >> >> My revision seems the obvious way to do it to me, but I can see that if >> someone was working with what Joe was working with, that one could be >> lead to think up his revision. I know that I myself have missed the >> obvious in many circumstance. > > I believe this will work, but it's been so long since I did this work. > I think the problem was that :M used to match "eel" when USE_GNOME > contained "eel2". But that doesn't appear to be the case anymore. That makes perfect sense. It does look like you had to work around a bug in make. I have actually looked at the code in make where it does the :M (it is the function Str_Match is str.c) and this bug has clearly been fixed now. Stephen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4655D835.3080709>