From owner-svn-src-head@freebsd.org Thu Mar 15 16:17:03 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7CD1EF5E151; Thu, 15 Mar 2018 16:17:03 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2BDB069270; Thu, 15 Mar 2018 16:17:03 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 25AEC18455; Thu, 15 Mar 2018 16:17:03 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w2FGH2Xx067264; Thu, 15 Mar 2018 16:17:02 GMT (envelope-from cem@FreeBSD.org) Received: (from cem@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w2FGH2MT067263; Thu, 15 Mar 2018 16:17:02 GMT (envelope-from cem@FreeBSD.org) Message-Id: <201803151617.w2FGH2MT067263@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: cem set sender to cem@FreeBSD.org using -f From: Conrad Meyer Date: Thu, 15 Mar 2018 16:17:02 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r331007 - head/sys/crypto/aesni X-SVN-Group: head X-SVN-Commit-Author: cem X-SVN-Commit-Paths: head/sys/crypto/aesni X-SVN-Commit-Revision: 331007 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 16:17:03 -0000 Author: cem Date: Thu Mar 15 16:17:02 2018 New Revision: 331007 URL: https://svnweb.freebsd.org/changeset/base/331007 Log: aesni(4): Stylistic/comment enhancements Improve clarity of a comment and style(9) some areas. No functional change. Reported by: markj (on review of a mostly-copied driver) Sponsored by: Dell EMC Isilon Modified: head/sys/crypto/aesni/aesni.c Modified: head/sys/crypto/aesni/aesni.c ============================================================================== --- head/sys/crypto/aesni/aesni.c Thu Mar 15 15:13:17 2018 (r331006) +++ head/sys/crypto/aesni/aesni.c Thu Mar 15 16:17:02 2018 (r331007) @@ -327,8 +327,8 @@ unhandled: return (EINVAL); } /* - * Free sessions goes first, so if first session is used, we need to - * allocate one. + * Free sessions are inserted at the head of the list. So if the first + * session is used, none are free and we must allocate a new one. */ ses = TAILQ_FIRST(&sc->sessions); if (ses == NULL || ses->used) { @@ -403,11 +403,13 @@ aesni_freesession(device_t dev, uint64_t tid) static int aesni_process(device_t dev, struct cryptop *crp, int hint __unused) { - struct aesni_softc *sc = device_get_softc(dev); - struct aesni_session *ses = NULL; + struct aesni_softc *sc; + struct aesni_session *ses; struct cryptodesc *crd, *enccrd, *authcrd; int error, needauth; + sc = device_get_softc(dev); + ses = NULL; error = 0; enccrd = NULL; authcrd = NULL; @@ -538,7 +540,7 @@ static device_method_t aesni_methods[] = { DEVMETHOD(cryptodev_freesession, aesni_freesession), DEVMETHOD(cryptodev_process, aesni_process), - {0, 0}, + DEVMETHOD_END }; static driver_t aesni_driver = {