From owner-freebsd-current@FreeBSD.ORG Thu Feb 19 02:43:51 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 505FC16A4CE for ; Thu, 19 Feb 2004 02:43:51 -0800 (PST) Received: from kazi.fit.vutbr.cz (kazi.fit.vutbr.cz [147.229.8.12]) by mx1.FreeBSD.org (Postfix) with ESMTP id BEE9443D1D for ; Thu, 19 Feb 2004 02:43:50 -0800 (PST) (envelope-from cejkar@fit.vutbr.cz) Received: from kazi.fit.vutbr.cz (localhost [127.0.0.1]) by kazi.fit.vutbr.cz (8.12.11/8.12.11) with ESMTP id i1JAhmlc092683 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Thu, 19 Feb 2004 11:43:48 +0100 (CET) Received: (from cejkar@localhost) by kazi.fit.vutbr.cz (8.12.11/8.12.5/Submit) id i1JAhmLV092682; Thu, 19 Feb 2004 11:43:48 +0100 (CET) X-Authentication-Warning: kazi.fit.vutbr.cz: cejkar set sender to cejkar@fit.vutbr.cz using -f Date: Thu, 19 Feb 2004 11:43:48 +0100 From: Rudolf Cejka To: Nate Lawson Message-ID: <20040219104348.GA90895@fit.vutbr.cz> References: <20040218190439.GA84386@fit.vutbr.cz> <20040218213802.W38635@root.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040218213802.W38635@root.org> User-Agent: Mutt/1.4.2i X-Scanned-By: MIMEDefang 2.16 (www . roaringpenguin . com / mimedefang) cc: freebsd-current@freebsd.org Subject: Re: Problems with power button after latest acpi_button.c 1.18 change X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2004 10:43:51 -0000 Nate Lawson wrote (2004/02/18): > Please test the following to make sure it fixes your problems with the > power/sleep buttons. Hello, I'm sorry, I had to go sleep for some time... > Index: acpi.c > diff -u -r1.116 acpi.c > ... > Index: acpi_button.c > diff -u -r1.18 acpi_button.c > ... Nate Lawson wrote (2004/02/18): > I just committed a fix, let me know if it doesn't work for you. Unfortunately, current revisions src/sys/dev/acpica/acpi.c,v 1.117 and src/sys/dev/acpica/acpi_button.c,v 1.19 still does not help to me (and as I saw the others too) and the behavior is still half-functional. I have modified my backout-patch to the current revision, which again returns power button to fully working state (atleast from my acpi-user's view). --- sys/dev/acpica/acpi_button.c.orig Thu Feb 19 06:35:20 2004 +++ sys/dev/acpica/acpi_button.c Thu Feb 19 11:27:12 2004 @@ -146,16 +146,6 @@ } acpi_device_enable_wake_capability(sc->button_handle, 1); - /* - * If we have fixed buttons defined in the FADT, remove them now that - * we have found one in the AML. Some systems define buttons both ways - * but only deliver events to the AML object. - */ - if (event == ACPI_EVENT_POWER_BUTTON && AcpiGbl_FADT->PwrButton == 0) - AcpiRemoveFixedEventHandler(event, acpi_event_power_button_sleep); - if (event == ACPI_EVENT_SLEEP_BUTTON && AcpiGbl_FADT->SleepButton == 0) - AcpiRemoveFixedEventHandler(event, acpi_event_sleep_button_sleep); - return_VALUE (0); } -- Rudolf Cejka http://www.fit.vutbr.cz/~cejkar Brno University of Technology, Faculty of Information Technology Bozetechova 2, 612 66 Brno, Czech Republic