From owner-svn-src-head@freebsd.org Wed Aug 22 08:18:51 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D195E1081319; Wed, 22 Aug 2018 08:18:51 +0000 (UTC) (envelope-from johalun0@gmail.com) Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FC1F896D5; Wed, 22 Aug 2018 08:18:51 +0000 (UTC) (envelope-from johalun0@gmail.com) Received: by mail-wm0-x241.google.com with SMTP id s9-v6so1188924wmh.3; Wed, 22 Aug 2018 01:18:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N8neAv4HtWjtMx7I69RI1NlV0qjTq/IytARF+sBRYDc=; b=ctebczY5EVAJvF0+bVmRbdkFGLtimY7L/W7opIIOzLeFZNZBDcD/8SShi9Y0DLlv6X FXkoSarQsU3GXJKKKVVgnsMfwsARQrd4kpjeN1JQbLoqcsqYte4d+pbI7Xl3rl8Rh+GB zrPZ5gRUX5BJWK0HuwRuUYIRXin108/TPbg5FVvY2OHjrOXQ7ximt+YvoG2QHHUqvZU6 YBiYBlujk8i49LH12nyZIv6q/WdTHUfklR3LPmiRze2yTXsEfTMO2xIjqPJ1Y3ZZy44A dm9/eVSYRFNAoXfHWKyqPgwQUzl8F5DFO3LcCo8TupLzCyswpi86bLRO64vhiUT+jEHW a06w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N8neAv4HtWjtMx7I69RI1NlV0qjTq/IytARF+sBRYDc=; b=SUrF0coBkGNZqo1Uq85OzEpg0B+9niZDvNu7KP8DhlwcTBMNo5qh1mal5IUXQk2mRe o9j+3RUhx16k+r9TlR4uJqeby42Ld4oC894Tg4zSTE/Hm7h2QTXj7tAQc3spGlI9d0o6 h6uzKKMvYeU8TuPrYDPJWDYtPuvjYR8A0lpj6cVByDFgzI61FZg2Dia1rvMogBiIvyI2 uiecKowHSp4FdEnDzxXBDNSzfUiNQBGtz0jemDlHquz0iURFKYN77AdVirY+tICMKT9D HwQbf1yXF+siZ89KSCM6XJ6TK/tTiWd5hiFfndDjCSC21dFCUWeSkvsbDYVuPWRLdLLF ZwVw== X-Gm-Message-State: APzg51DghO/P8SM6uib7V+RcX0/ABBI0uuasXtANs6e14jqVgdCOOst6 HnQ03oW2qIlLTGdf8dof32YImLz2lecCM3yaBAxv1Q== X-Google-Smtp-Source: ANB0Vdb/S3Ck5iepfGlotIlRpaNHbhGxAUVPxGa2+m2anT0dUvEOfjtWr2Y3g7RoGcN8zxOsCuIbay21+9AKsjFtgIs= X-Received: by 2002:a1c:55c2:: with SMTP id j185-v6mr1730770wmb.104.1534925930249; Wed, 22 Aug 2018 01:18:50 -0700 (PDT) MIME-Version: 1.0 References: <201808220150.w7M1oDeA012487@repo.freebsd.org> <13c977be-0ee7-688d-4f61-837ccb5d5273@selasky.org> <860aa5fa-1004-c19e-b928-1cbcc2c90f6f@FreeBSD.org> In-Reply-To: <860aa5fa-1004-c19e-b928-1cbcc2c90f6f@FreeBSD.org> From: Johannes Lundberg Date: Wed, 22 Aug 2018 09:18:13 +0100 Message-ID: Subject: Re: svn commit: r338172 - in head: . sys/amd64/conf sys/dev/drm sys/dev/drm2 sys/dev/drm2/i915 sys/dev/drm2/radeon sys/dev/drm2/radeon/reg_srcs sys/dev/drm2/ttm sys/i386/conf sys/modules sys/modules/dr... To: jhb@freebsd.org Cc: Hans Petter Selasky , Matthew Macy , Andriy Gapon , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 08:18:52 -0000 On Wed, Aug 22, 2018 at 8:51 AM John Baldwin wrote: > On 8/22/18 8:41 AM, Hans Petter Selasky wrote: > > On 8/22/18 9:35 AM, Matthew Macy wrote: > >> Johannes - do you know off hand? > >> -M > > > > Hi, > > > > This function is still not implemented. This is part of the LGPLv2 part. > > > Yeah, I confused it with another function... > Probably the function and the restore companion doesn't have to panic. > > > > --HPS > > > >> static inline void > >> linux_pci_save_state(struct pci_dev *pdev) > >> { > >> > >> panic("implment me!!"); > >> UNIMPLEMENTED(); > >> } > > Can't this just use pci_save_state() of the FreeBSD device_t? If there > are bits of PCI space that pci_save_state() isn't saving that we need to > save/restore, we should probably just add those to the FreeBSD one > (e.g. additional capability registers). > Yes, it seems i915 has been patched to do just this. We can have the linux_* functions call the freebsd equivalent so that will fix amd/radeon. > -- > John Baldwin >