From owner-freebsd-current@freebsd.org Tue Nov 17 08:10:40 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DA6852D3CE7 for ; Tue, 17 Nov 2020 08:10:40 +0000 (UTC) (envelope-from vladimir@kondratyev.su) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4CZzCN471sz3qLs for ; Tue, 17 Nov 2020 08:10:40 +0000 (UTC) (envelope-from vladimir@kondratyev.su) Received: by mailman.nyi.freebsd.org (Postfix) id 8D45D2D42C4; Tue, 17 Nov 2020 08:10:40 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8CF932D3CE6; Tue, 17 Nov 2020 08:10:40 +0000 (UTC) (envelope-from vladimir@kondratyev.su) Received: from corp.infotel.ru (corp.infotel.ru [195.170.219.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4CZzCM4dBpz3qRG; Tue, 17 Nov 2020 08:10:39 +0000 (UTC) (envelope-from vladimir@kondratyev.su) Received: from corp (corp.infotel.ru [195.170.219.3]) by corp.infotel.ru (Postfix) with ESMTP id 797DB148E13; Tue, 17 Nov 2020 11:10:38 +0300 (MSK) X-Virus-Scanned: amavisd-new at corp.infotel.ru Received: from corp.infotel.ru ([195.170.219.3]) by corp (corp.infotel.ru [195.170.219.3]) (amavisd-new, port 10024) with ESMTP id EU40zjlJ7aW8; Tue, 17 Nov 2020 11:10:37 +0300 (MSK) Received: from mail.cicgroup.ru (unknown [195.170.219.74]) by corp.infotel.ru (Postfix) with ESMTP id 8ED8E148E00; Tue, 17 Nov 2020 11:10:37 +0300 (MSK) Received: from mail.cicgroup.ru (localhost [127.0.0.1]) by mail.cicgroup.ru (Postfix) with ESMTP id 2FDA442211F; Tue, 17 Nov 2020 11:07:03 +0300 (MSK) X-Virus-Scanned: amavisd-new at cicgroup.ru Received: from mail.cicgroup.ru ([127.0.0.1]) by mail.cicgroup.ru (mail.cicgroup.ru [127.0.0.1]) (amavisd-new, port 10024) with SMTP id lhKPa18KVedz; Tue, 17 Nov 2020 11:07:00 +0300 (MSK) Received: from localhost (localhost [127.0.0.1]) by mail.cicgroup.ru (Postfix) with ESMTPA id 3276C42211C; Tue, 17 Nov 2020 11:07:00 +0300 (MSK) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_78f0970818859361063826d296ba337a" Date: Tue, 17 Nov 2020 11:07:00 +0300 From: Vladimir Kondratyev To: Yuri Pankov Cc: current@freebsd.org, owner-freebsd-current@freebsd.org Subject: Re: acpi_wmi noisy without EC In-Reply-To: <7b80877ae59fdd90f2f3b5dbf3db2113@kondratyev.su> References: <7dc142d3-1e0b-41d4-bdb4-7217bd09bbef@www.fastmail.com> <7b80877ae59fdd90f2f3b5dbf3db2113@kondratyev.su> Message-ID: X-Sender: vladimir@kondratyev.su User-Agent: Roundcube Webmail/1.3.5 X-Rspamd-Queue-Id: 4CZzCM4dBpz3qRG X-Spamd-Bar: / X-Spamd-Result: default: False [-0.90 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; HAS_ATTACHMENT(0.00)[]; MIME_BASE64_TEXT_BOGUS(1.00)[]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MIME_BASE64_TEXT(0.10)[]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[195.170.219.3:from]; ASN(0.00)[asn:8299, ipnet:195.170.192.0/19, country:RU]; MIME_TRACE(0.00)[0:+,1:+,2:+]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; RCVD_COUNT_FIVE(0.00)[6]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/mixed,text/plain,text/x-diff]; DMARC_NA(0.00)[kondratyev.su]; AUTH_NA(1.00)[]; SPAMHAUS_ZRD(0.00)[195.170.219.3:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[no SPF record]; MAILMAN_DEST(0.00)[current,owner-freebsd-current] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2020 08:10:40 -0000 --=_78f0970818859361063826d296ba337a Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On 2020-11-17 10:57, Vladimir Kondratyev wrote: > On 2020-11-17 03:00, Yuri Pankov wrote: >> I have started seeing the following on boot since some time: >> >> acpi_wmi0: on acpi0 >> acpi_wmi0: cannot find EC device >> device_attach: acpi_wmi0 attach returned 6 >> acpi_wmi0: on acpi0 >> acpi_wmi0: cannot find EC device >> device_attach: acpi_wmi0 attach returned 6 >> acpi_wmi0: on acpi0 >> acpi_wmi0: cannot find EC device >> device_attach: acpi_wmi0 attach returned 6 >> acpi_wmi0: on acpi0 >> acpi_wmi0: cannot find EC device >> device_attach: acpi_wmi0 attach returned 6 >> >> Likely following this commit: >> >> commit 708d048ccfdacf6199cc08a56aa05a9c899441fd >> Author: Vladimir Kondratyev >> Date: Sat Oct 31 22:19:39 2020 +0000 >> >> acpi_wmi(4): Add ACPI_PNP_INFO >> >> While the reason is obvious -- there's no EC in this system (Gigabyte >> X299X AORUS MASTER desktop motherboard), at least searching the >> `acpidump -dt` output doesn't show any PNP0C09 entries -- it certainly >> looks like "something is broken" when first noticed. I wonder if we >> could/should handle this gracefully -- no EC, do nothing, simply exit? > > Following patch should ignore missing EC like Linux does. Could you > test it? > > diff --git a/sys/dev/acpi_support/acpi_wmi.c > b/sys/dev/acpi_support/acpi_wmi.c > index 379cfd1705f1..efae96cdcc9a 100644 > --- a/sys/dev/acpi_support/acpi_wmi.c > +++ b/sys/dev/acpi_support/acpi_wmi.c > @@ -246,7 +246,7 @@ acpi_wmi_attach(device_t dev) > if ((sc->ec_dev = devclass_get_device(devclass_find("acpi_ec"), 0)) > == NULL) > device_printf(dev, "cannot find EC device\n"); > - else if (ACPI_FAILURE((status = > AcpiInstallNotifyHandler(sc->wmi_handle, > + if (ACPI_FAILURE((status = AcpiInstallNotifyHandler(sc->wmi_handle, > ACPI_DEVICE_NOTIFY, acpi_wmi_notify_handler, sc)))) > device_printf(sc->wmi_dev, "couldn't install notify handler - %s\n", > AcpiFormatException(status)); > @@ -701,6 +701,8 @@ acpi_wmi_ec_handler(UINT32 function, > ACPI_PHYSICAL_ADDRESS address, > return (AE_BAD_PARAMETER); > if (address + (width / 8) - 1 > 0xFF) > return (AE_BAD_ADDRESS); > + if (sc->ec_dev == NULL) > + return (AE_NOT_FOUND); > if (function == ACPI_READ) > *value = 0; > ec_addr = address; @#@##! Web client ate all the tabs. Patch is in attachment. -- WBR Vladimir Kondratyev --=_78f0970818859361063826d296ba337a Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=acpi_wmi.c.patch Content-Disposition: attachment; filename=acpi_wmi.c.patch; size=996 ZGlmZiAtLWdpdCBhL3N5cy9kZXYvYWNwaV9zdXBwb3J0L2FjcGlfd21pLmMgYi9zeXMvZGV2L2Fj cGlfc3VwcG9ydC9hY3BpX3dtaS5jCmluZGV4IDM3OWNmZDE3MDVmMS4uZWZhZTk2Y2RjYzlhIDEw MDY0NAotLS0gYS9zeXMvZGV2L2FjcGlfc3VwcG9ydC9hY3BpX3dtaS5jCisrKyBiL3N5cy9kZXYv YWNwaV9zdXBwb3J0L2FjcGlfd21pLmMKQEAgLTI0Niw3ICsyNDYsNyBAQCBhY3BpX3dtaV9hdHRh Y2goZGV2aWNlX3QgZGV2KQogCWlmICgoc2MtPmVjX2RldiA9IGRldmNsYXNzX2dldF9kZXZpY2Uo ZGV2Y2xhc3NfZmluZCgiYWNwaV9lYyIpLCAwKSkKIAkgICAgPT0gTlVMTCkKIAkJZGV2aWNlX3By aW50ZihkZXYsICJjYW5ub3QgZmluZCBFQyBkZXZpY2VcbiIpOwotCWVsc2UgaWYgKEFDUElfRkFJ TFVSRSgoc3RhdHVzID0gQWNwaUluc3RhbGxOb3RpZnlIYW5kbGVyKHNjLT53bWlfaGFuZGxlLAor CWlmIChBQ1BJX0ZBSUxVUkUoKHN0YXR1cyA9IEFjcGlJbnN0YWxsTm90aWZ5SGFuZGxlcihzYy0+ d21pX2hhbmRsZSwKIAkJICAgIEFDUElfREVWSUNFX05PVElGWSwgYWNwaV93bWlfbm90aWZ5X2hh bmRsZXIsIHNjKSkpKQogCQlkZXZpY2VfcHJpbnRmKHNjLT53bWlfZGV2LCAiY291bGRuJ3QgaW5z dGFsbCBub3RpZnkgaGFuZGxlciAtICVzXG4iLAogCQkgICAgQWNwaUZvcm1hdEV4Y2VwdGlvbihz dGF0dXMpKTsKQEAgLTcwMSw2ICs3MDEsOCBAQCBhY3BpX3dtaV9lY19oYW5kbGVyKFVJTlQzMiBm dW5jdGlvbiwgQUNQSV9QSFlTSUNBTF9BRERSRVNTIGFkZHJlc3MsCiAJCXJldHVybiAoQUVfQkFE X1BBUkFNRVRFUik7CiAJaWYgKGFkZHJlc3MgKyAod2lkdGggLyA4KSAtIDEgPiAweEZGKQogCQly ZXR1cm4gKEFFX0JBRF9BRERSRVNTKTsKKwlpZiAoc2MtPmVjX2RldiA9PSBOVUxMKQorCQlyZXR1 cm4gKEFFX05PVF9GT1VORCk7CiAJaWYgKGZ1bmN0aW9uID09IEFDUElfUkVBRCkKIAkJKnZhbHVl ID0gMDsKIAllY19hZGRyID0gYWRkcmVzczsK --=_78f0970818859361063826d296ba337a--