From owner-freebsd-ports-bugs@freebsd.org Fri Dec 9 04:04:26 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E2DCDC6D7B2 for ; Fri, 9 Dec 2016 04:04:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B851414AE for ; Fri, 9 Dec 2016 04:04:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id uB944QOm012799 for ; Fri, 9 Dec 2016 04:04:26 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 214184] audio/amarok-kde4: fails to build with ffmpeg 3.x Date: Fri, 09 Dec 2016 04:04:26 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: matthew@reztek.cz X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kde@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Dec 2016 04:04:27 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D214184 matthew@reztek.cz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthew@reztek.cz --- Comment #12 from matthew@reztek.cz --- (In reply to Raphael Kubo da Costa from comment #9) Considering that I don't use Amarok at all and kinda despise it, it's not w= orth opening another PR. I was merely trying to clear the way for FFmpeg 3.x, an= d I was fixing other obvious issue encountered on the way. Although I like the = idea of separate change sets for logically independent changes, that is just not practical for a contributor when PR handling times are measured in weeks if= not months (this one took just over a month). Lumping all the changes for a port into a single PR is the only (somewhat) practical way to make measurable forwards progress. When I was testing the patch for newer FFmpeg, I built on a live system and= I had turned off all the options in Amarok to minimize the dependencies. Of course, this caused me to notice any option that does not properly switch o= ff, because the dependencies were present in the live build environment so the compilation will find and use those which are not properly disabled during = the configure phase. Testing in Poudriere will NOT identify such problems unless you go out of your way to ensure the libraries are present in the build jai= l, i.e. temporarily make the all the depends non-optional. Without the change suggested by tcberner, Amarok is linking against libmtp if it's present regardless of the option state. That is incorrect and I have tested the proposed solution, but I'm already bending over backwards here and don't ne= ed to go further. I simply have more productive things to do than atomize fixe= s to software I'd rather just delete. --=20 You are receiving this mail because: You are on the CC list for the bug.=