From nobody Wed Jan 14 11:17:40 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4drk9d1T6Nz6PVwH; Wed, 14 Jan 2026 11:17:41 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4drk9c6hYkz3kSW; Wed, 14 Jan 2026 11:17:40 +0000 (UTC) (envelope-from brooks@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768389460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PTLkZM7BxBRZiV7pZ5bJrWcz4lhCcvzhLLoE1hXOG+8=; b=ZNW3HRcbjBjGNlZyAX6ER2i72roWTz6G/g5KW8/3ybXL7guag/lG+zMajHDe75wYJN82Hq 9iVVTg4XVZxU4yctF+rEE9NGVnlMtYa+lKVNCJLmVaqGfMSRZ9mVU74AWx/BVe5HxjuPnS 0YsogwJucEsuErHB59BlhdNaT7TX6ShMfNFIfUlve6sxO/WcGpi+3Tn1de7tbOaEyu4u6Q u6q2jKlRxh+y3sghcBQQqxKOsXMjdn/lOI9hVpANuc3EEfcQ4aqFievz6/zPjkMgowgnu8 zI9p8fBvsp4AjXuctVPBr69qIWVycu27RcAd06vf5iR6hIASO2hX62AYLxF7CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768389460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PTLkZM7BxBRZiV7pZ5bJrWcz4lhCcvzhLLoE1hXOG+8=; b=PLSHiozRtITnJRoKUn7KbmARXkXizgDvVQIxOpfVMgumyCQUxeKI/ixLZr5psHjA9SDo3w tDVYVOsZIiN1geKjnuGUTpYqCFRt0LR//O6np/FqXwV4oIB3mB1jSHPZNrC0kvVzIq0W8b tJq6BLzq/QmBjKGmhC7R0bYUtp/UJpiKvTEDB7bG3u3WIdhkjDXuCAiOuVAuWfE5lr7u8n 9vrZdJH401gR9ERNff4GSMEEGswVS8TABNTewTD/29E5ujWEQm+52JW/xgdKqV5NX5RMZV YphPOcG6g6v55X+n2d1X+Jg6BRviY8pTo4TWaZJL+XPMGm6+FQS/XmwgVHL3Hw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768389460; a=rsa-sha256; cv=none; b=sKjf9zFkTDfo/0BGcpc9o7zAjY3jEKtVhhqnmOQfffQt1ZDvv5G1O5WZfG5c4oG+OnwSiS 24clwKnjWJmjE/UAcKoAw9x6cbjaH1X/iBJTykmfgLRfBK63ManKreQBFTlg+P4Ef/Ed1k D3vMf9edALsjdB6ego2JkDgkd2e/j/kxH+1XzuoVmVg+zYMpdLzd803rOKoR8ENIJ+/z30 E+65w3R6df0EAtOqO6GaY7xLG1TRKWmvGVqi7g+MqXLyDtFAJVX4p3b07h4syD26cffj5I JLM7fi4paQVLayHRzSWtNT8fPqp7Zs0Sf1ANjWI8JoO2MzApLu6mjsyNXOGYIA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: brooks/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4drk9c5lNSzvSk; Wed, 14 Jan 2026 11:17:40 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 1D2613C01A0; Wed, 14 Jan 2026 11:17:40 +0000 (UTC) Date: Wed, 14 Jan 2026 11:17:40 +0000 From: Brooks Davis To: Christos Margiolis Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: f74f891581bc - main - src.opts: Introduce MK_SOUND Message-ID: References: <6965024b.c6cd.6cdf7962@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6965024b.c6cd.6cdf7962@gitrepo.freebsd.org> On Mon, Jan 12, 2026 at 02:16:43PM +0000, Christos Margiolis wrote: > The branch main has been updated by christos: > > URL: https://cgit.FreeBSD.org/src/commit/?id=f74f891581bc4df20431607de9b761107f6a0aa7 > > commit f74f891581bc4df20431607de9b761107f6a0aa7 > Author: Christos Margiolis > AuthorDate: 2026-01-12 14:16:35 +0000 > Commit: Christos Margiolis > CommitDate: 2026-01-12 14:16:35 +0000 > > src.opts: Introduce MK_SOUND > > PR: 291853 > Sponsored by: The FreeBSD Foundation > MFC after: 1 week > Reviewed by: zarychtam_plan-b.pwste.edu.pl, markj > Differential Revision: https://reviews.freebsd.org/D54456 > --- > lib/Makefile | 3 ++- > libexec/rc/rc.d/Makefile | 7 ++++--- > sbin/devd/Makefile | 12 +++++++----- > share/mk/src.opts.mk | 6 ++++++ > tools/build/mk/OptionalObsoleteFiles.inc | 13 +++++++++++++ > tools/build/options/WITH_SOUND | 1 + > usr.bin/Makefile | 2 ++ > usr.sbin/Makefile | 4 +++- > 8 files changed, 38 insertions(+), 10 deletions(-) > > diff --git a/lib/Makefile b/lib/Makefile > index 216ba1d58473..d06488a33fb9 100644 > --- a/lib/Makefile > +++ b/lib/Makefile > @@ -176,7 +176,6 @@ SUBDIR+= clang > .endif > > SUBDIR.${MK_CUSE}+= libcuse > -SUBDIR.${MK_CUSE}+= virtual_oss > SUBDIR.${MK_TOOLCHAIN}+=libpe > SUBDIR.${MK_DIALOG}+= libdpv libfigpar > SUBDIR.${MK_FDT}+= libfdt > @@ -238,6 +237,8 @@ SUBDIR.${MK_PMC}+= libpmc libpmcstat > SUBDIR.${MK_RADIUS_SUPPORT}+= libradius > SUBDIR.${MK_SENDMAIL}+= libmilter libsm libsmdb libsmutil > SUBDIR.${MK_TELNET}+= libtelnet > +SUBDIR.${MK_SOUND}+= libmixer > +SUBDIR.${MK_SOUND}+= virtual_oss This should be SUBDIR.${MK_CUSE}.${MK_SOUND} or MK_CUSE=no + MK_SOUND=yes will be broken. There's another case in use.sbin/Makefile. -- Brooks