From owner-svn-src-all@FreeBSD.ORG  Thu Oct 18 14:11:28 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 16300451;
 Thu, 18 Oct 2012 14:11:28 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117])
 by mx1.freebsd.org (Postfix) with ESMTP id 8126A8FC16;
 Thu, 18 Oct 2012 14:11:27 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id q9IEBKv4049459;
 Thu, 18 Oct 2012 18:11:20 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id q9IEBKqg049458;
 Thu, 18 Oct 2012 18:11:20 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Thu, 18 Oct 2012 18:11:20 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Andre Oppermann <andre@FreeBSD.org>
Subject: Re: svn commit: r241688 - head/sys/net
Message-ID: <20121018141120.GJ89655@FreeBSD.org>
References: <201210181408.q9IE8QwE053495@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201210181408.q9IE8QwE053495@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Oct 2012 14:11:28 -0000

On Thu, Oct 18, 2012 at 02:08:26PM +0000, Andre Oppermann wrote:
A> Author: andre
A> Date: Thu Oct 18 14:08:26 2012
A> New Revision: 241688
A> URL: http://svn.freebsd.org/changeset/base/241688
A> 
A> Log:
A>   Use LOG_WARNING level in in_attachdomain1() instead of printf().
A>   
A>   Submitted by:	vijju.singh-at-gmail.com
A> 
A> Modified:
A>   head/sys/net/if.c
A> 
A> Modified: head/sys/net/if.c
A> ==============================================================================
A> --- head/sys/net/if.c	Thu Oct 18 13:57:28 2012	(r241687)
A> +++ head/sys/net/if.c	Thu Oct 18 14:08:26 2012	(r241688)
A> @@ -711,8 +711,8 @@ if_attachdomain1(struct ifnet *ifp)
A>  		return;
A>  	if (ifp->if_afdata_initialized >= domain_init_status) {
A>  		IF_AFDATA_UNLOCK(ifp);
A> -		printf("if_attachdomain called more than once on %s\n",
A> -		    ifp->if_xname);
A> +		log(LOG_WARNING, "if_attachdomain called more than once "
A> +		    "on %s\n", ifp->if_xname);
A>  		return;
A>  	}
A>  	ifp->if_afdata_initialized = domain_init_status;

It'll be even more perfect if done as

"%s called more than once on %s\n", __func__, ifp->if_xname

And do we need "\n" for log(9)?

-- 
Totus tuus, Glebius.