Date: Thu, 18 Oct 2012 18:11:20 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Andre Oppermann <andre@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r241688 - head/sys/net Message-ID: <20121018141120.GJ89655@FreeBSD.org> In-Reply-To: <201210181408.q9IE8QwE053495@svn.freebsd.org> References: <201210181408.q9IE8QwE053495@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 18, 2012 at 02:08:26PM +0000, Andre Oppermann wrote: A> Author: andre A> Date: Thu Oct 18 14:08:26 2012 A> New Revision: 241688 A> URL: http://svn.freebsd.org/changeset/base/241688 A> A> Log: A> Use LOG_WARNING level in in_attachdomain1() instead of printf(). A> A> Submitted by: vijju.singh-at-gmail.com A> A> Modified: A> head/sys/net/if.c A> A> Modified: head/sys/net/if.c A> ============================================================================== A> --- head/sys/net/if.c Thu Oct 18 13:57:28 2012 (r241687) A> +++ head/sys/net/if.c Thu Oct 18 14:08:26 2012 (r241688) A> @@ -711,8 +711,8 @@ if_attachdomain1(struct ifnet *ifp) A> return; A> if (ifp->if_afdata_initialized >= domain_init_status) { A> IF_AFDATA_UNLOCK(ifp); A> - printf("if_attachdomain called more than once on %s\n", A> - ifp->if_xname); A> + log(LOG_WARNING, "if_attachdomain called more than once " A> + "on %s\n", ifp->if_xname); A> return; A> } A> ifp->if_afdata_initialized = domain_init_status; It'll be even more perfect if done as "%s called more than once on %s\n", __func__, ifp->if_xname And do we need "\n" for log(9)? -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121018141120.GJ89655>