From owner-cvs-all  Wed Feb 27 23:35:52 2002
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4ED7037B417; Wed, 27 Feb 2002 23:35:49 -0800 (PST)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id SAA05470;
	Thu, 28 Feb 2002 18:35:35 +1100
Date: Thu, 28 Feb 2002 18:36:07 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@gamplex.bde.org>
To: Brooks Davis <brooks@one-eyed-alien.net>
Cc: Mikhail Teterin <mi@aldan.algebra.com>, <brooks@FreeBSD.org>,
	<cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/dev/awi if_awi_pccard.c
In-Reply-To: <20020227094511.A546@Odin.AC.HMC.Edu>
Message-ID: <20020228182700.L51838-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Wed, 27 Feb 2002, Brooks Davis wrote:

> On Wed, Feb 27, 2002 at 10:56:38PM +1100, Bruce Evans wrote:
> > This an indication that if_name should have type "const char *", and
> > that we don't have -Wwrite-strings turned on for the kernel yet.
>
> If you have a suggestion for a less bogus interim fix, I'd be happy to
> commmit it.

I guess this one is OK for an interim fix, since we will get warnings
about it later when we enable -Wwrite-strings and many other network
drivers have similar code.  I slightly prefer the changed version anyway.
device_get_name() isn't all that useful in places that know the device
name.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message