From owner-svn-src-head@FreeBSD.ORG  Sun Nov 25 19:28:59 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id F39AAA52;
 Sun, 25 Nov 2012 19:28:58 +0000 (UTC)
 (envelope-from pawel@dawidek.net)
Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72])
 by mx1.freebsd.org (Postfix) with ESMTP id B1DB88FC08;
 Sun, 25 Nov 2012 19:28:57 +0000 (UTC)
Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149])
 by mail.dawidek.net (Postfix) with ESMTPSA id 16B74CEE;
 Sun, 25 Nov 2012 20:27:09 +0100 (CET)
Date: Sun, 25 Nov 2012 20:30:08 +0100
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Konstantin Belousov <kostikbel@gmail.com>
Subject: Re: svn commit: r243142 - in head/sys: fs/nfsclient kern sys
Message-ID: <20121125193008.GN1460@garage.freebsd.pl>
References: <201211160825.qAG8P6v6047507@svn.freebsd.org>
 <20121124222408.GH1460@garage.freebsd.pl>
 <20121125162152.GA3013@kib.kiev.ua>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="i6vqABX3nJKXLk01"
Content-Disposition: inline
In-Reply-To: <20121125162152.GA3013@kib.kiev.ua>
X-OS: FreeBSD 10.0-CURRENT amd64
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Nov 2012 19:28:59 -0000


--i6vqABX3nJKXLk01
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Nov 25, 2012 at 06:21:52PM +0200, Konstantin Belousov wrote:
> On Sat, Nov 24, 2012 at 11:24:08PM +0100, Pawel Jakub Dawidek wrote:
> > I think we should move zpfind_locked() under 'pid <=3D PID_MAX':
> >=20
> > 	sx_slock(&allproc_lock);
> > 	if (pid <=3D PID_MAX) {
> > 		p =3D pfind_locked(pid);
> > 		if (p =3D=3D NULL && (flags & PGET_NOTWEXIT) =3D=3D 0)
> > 			p =3D zpfind_locked(pid);
> > 	} else if ((flags & PGET_NOTID) =3D=3D 0) {
> > 		p =3D pfind_tid_locked(pid);
> > 	} else {
> > 		p =3D NULL;
> > 	}
> > 	sx_sunlock(&allproc_lock);
> > 	if (p =3D=3D NULL)
> > 		return (ESRCH);
> >=20
>=20
> Yes, I agree. Please remove {} for one-line blocks.

If I need braces in one place, I put them into all the places so that
all the elses are aligned. style(9) does allow that.

--=20
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

--i6vqABX3nJKXLk01
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlCyccAACgkQForvXbEpPzT3VgCggvcjjInHNPsmtHKUO+FJxA5m
LdkAoMzIIgZvEQpRuD/JIs4wW/jBweUr
=h3x4
-----END PGP SIGNATURE-----

--i6vqABX3nJKXLk01--