From owner-svn-ports-all@freebsd.org Wed Aug 10 08:57:48 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AB27FBB06DE; Wed, 10 Aug 2016 08:57:48 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pf0-x235.google.com (mail-pf0-x235.google.com [IPv6:2607:f8b0:400e:c00::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 78DB519A3; Wed, 10 Aug 2016 08:57:48 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pf0-x235.google.com with SMTP id p64so14119108pfb.1; Wed, 10 Aug 2016 01:57:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:reply-to:subject:references:to:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5zzlb32cjbr26xudxVm/FFUiLsvL6A0xhTVbuOMakQs=; b=d0JoPZhzh4LE5W3KNpBUTWcDfRDVYFIyM764IJOLsuNISRu40tvZjkfSIv0SND18fF l36XTdDBRcLEbRqQSewrzTEj1pualpOo2laixn/0miEgx6LoKRVeMeQzcvuG9rZ9hAPz JhgPxsEljyqpuXo5qap0c24aMrR7rdrQC20kvEhBlATI4X/80XJReNR9X7jKN/rjWaZG N7SmVVeb0yGCu27sdz/k39XeE3yCfGwCZt0Uq6WXoKAbRzpGUX47V0jHGryr6rQhDwa5 o1Uxj42fbqfsrFJ/gFOD0Wrk883AlBet7oBEnN+y6mlqgU08vetgnTlWYOzntaxQafbO UC3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:reply-to:subject:references:to:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=5zzlb32cjbr26xudxVm/FFUiLsvL6A0xhTVbuOMakQs=; b=AjYrE9ah9EwXWFHd6n7lx4NEpWLFUwplITUiGGcLnGyOWgHxfGplX0VCIbiLRqk0Xe XX1jfGqlerYpjuM4a9faratU4PYXKASwTnNzmnwUYG5nNGcIhkt3HqEnLlrEG1YGiv9w vK69BWzCqh7wKi6/xPnDUOZ9qj4jyYntL7MVxbX8yGVY0TVESpQKzRrZPlOe8SfIvRcy G1RGoeaXp1O90GPa8/3+RQ4hoDcnKAsEW5VlmFMSm95T3GJWiVEVL5HFZkPhG6RVlcnP QF1IZmtJkqeLQZ3aOxtFYvKk3flzDv/rqe410PvHl6HQET1jmTVEFF+Cc9KAI1VeXESH ZgOA== X-Gm-Message-State: AEkooutJ0DAzYZ2OjojjKW2pfsn/nW8+vqYPAQ0Sop8bHYQ86cz2HGaukaQeR5SLLW8KJw== X-Received: by 10.98.149.131 with SMTP id c3mr5167118pfk.73.1470819467916; Wed, 10 Aug 2016 01:57:47 -0700 (PDT) Received: from ?IPv6:2001:44b8:31ae:7b01:f985:3c4b:2a0c:8bea? (2001-44b8-31ae-7b01-f985-3c4b-2a0c-8bea.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01:f985:3c4b:2a0c:8bea]) by smtp.gmail.com with ESMTPSA id wa9sm62043996pac.35.2016.08.10.01.57.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Aug 2016 01:57:47 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r419993 - in head: mail/libmapi net/nanomsg References: <201608100821.u7A8LJqp055282@repo.freebsd.org> To: Emmanuel Vadot , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Kubilay Kocak Message-ID: Date: Wed, 10 Aug 2016 18:57:42 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Thunderbird/50.0a2 MIME-Version: 1.0 In-Reply-To: <201608100821.u7A8LJqp055282@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-AU Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2016 08:57:48 -0000 On 10/08/2016 6:21 PM, Emmanuel Vadot wrote: > +.if ${PORT_OPTIONS:MDOCS} > +CMAKE_ARGS+= -DCMAKE_INSTALL_MANDIR:STRING=man > +.else > +CMAKE_ARGS+= -DNN_ENABLE_DOC=OFF > .endif This block can/should be replaced with options helpers (placed under DOCS_BUILD_DEPENDS): DOCS_CMAKE_BOOL= NN_ENABLE_DOC DOCS_CMAKE_ON= -DCMAKE_INSTALL_MANDIR:STRING=man See Mk/bsd.options.mk for details. Please test (poudriere) with/without DOCS option to confirm that their cmake scripts accept -D${content}:BOOL=false (what Ports does) as well as 'OFF' for their NN_ENABLE_DOC cmake option.